- Issue created by @jurgenhaas
- π§πͺBelgium dataweb Kalmthout
Any idea on how to achieve this? Probably because of my lack on credits? π
- π©πͺGermany jurgenhaas Gottmadingen
Ah, that part of easy π. Edit the project page, there is a checkbox to opt in to it.
- π§πͺBelgium dataweb Kalmthout
It is not that i do not want but i think i did not review enough other issues so i have rights yet to activate it for this module? If I understand it correctly? Maybe we can also speed it up by adding other maintainers to the module? If so, if you are interested... :)
- π©πͺGermany jurgenhaas Gottmadingen
Thanks for offering that, but I do have so many projects to maintain already, that it wouldn't be smart to take on even more.
But if you go through the steps described here ( https://www.drupal.org/node/1011698 β ) you may be able to apply for the permission really quick, and I'd be happy to review that application then, which should also help.
When it comes to code style corrections, I've run that analysis just now, and there are only 3 items that should be fixed before applying:
FILE: /var/www/html/web/modules/contrib/ief_popup/ief_popup.module -------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------------------- 68 | WARNING | Line exceeds 80 characters; contains 82 characters 164 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "_process_ief_form" but expected | | "ief_popup__process_ief_form" 323 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "_ief_form_after_build" but expected | | "ief_popup__ief_form_after_build" --------------------------------------------------------------------------------------------------------------------------------------------------------------------
- π§πͺBelgium dataweb Kalmthout
@jurgenhaas I did the few changes and filled out the form to apply for "Trusted Contributor" as you suggested.
https://www.drupal.org/project/projectapplications/issues/3451948 β - πΏπ¦South Africa Gomez_in_the_South
Hi @dataweb - I see there are two minor changes requested in the application you linked to, that are pending your response.
- π¨π¦Canada chrisck BC, Canada
@dataweb I see the application for security advisory coverage closed 11 days ago due to lack of activity. As @gomez_in_the_south mentioned, there were only two minor changes requested to complete the application. I can offer to help maintain the module and continue with the application if you wish.
- π§πͺBelgium dataweb Kalmthout
Thx for reaching out @chrisck, I did the minor changes in the 2nd of June, see version 2.2.1. Apparently that was not enough to proceed automatically and probably the process was not that clear to me either. I did not know the process was closed to lack of activity either :-)
I'd be happy to have you as a co-maintainer on the project so i you want... i can add you.
- π¨π¦Canada chrisck BC, Canada
@dataweb Yes, I'd be happy to help as co-maintainer and follow up with security advisory coverage.
- πΊπΈUnited States Greg Boggs Portland Oregon
To get security coverage, the module must have a stable release, and a maintainer of the module must have permission to opt into coverage. To get permission to opt into coverage, a maintainer has to have created at least one module that was reviewed and approved by the module review team.
If you already have permission to opt projects in, you can click a box. If not, here's the process:
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... β