- Issue created by @shyam_bhatt
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:56am 25 September 2023 - 🇮🇳India shyam_bhatt Gujarat
To fix the above issue, Please check and review the patch.
After patch:
- Assigned to tanuja_02
@Shyam_Bhatt , I tried on 9.5.8 but not able to reproduce this issue.
- Issue was unassigned.
- 🇮🇳India nilesh.k
Hi,
patch #2 has been successfully applied on my local environment. I have also added screenshots, both before and after the translation.
Before patch
After patch
- 🇨🇭Switzerland saschaeggi Zurich
Can we get this as a branch so we can run the CI pipelines? That would be lovely, thank you!
- last update
over 1 year ago Patch Failed to Apply - First commit to issue fork.
- @shweta__sharma opened merge request.
- last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - Status changed to RTBC
about 1 year ago 12:44pm 18 October 2023 - 🇮🇳India shyam_bhatt Gujarat
I have checked the "MR !311", working fine. The CI pipeline checks are also passed for the same.
Please check the below image:
After MR:
+ Moving to RTBC
- Status changed to Needs work
about 1 year ago 11:59pm 20 December 2023 - 🇨🇦Canada chrisck BC, Canada
The MR needs a rebase or a re-roll. Patch could not apply.
- 🇨🇦Canada chrisck BC, Canada
Sorry for the multiple MRs, I'm trying to get a handle on GitLab and the failing pipeline test. I'm unable to delete the branches that I made.
- 🇮🇳India ravi kant Jaipur
I tried with branch '3389509-drag-handle-multiple-file' and this is solving issue.
But i am also not able to delete extra branches same as @chrisck - 🇮🇳India ravi kant Jaipur
ravi kant → changed the visibility of the branch 3389509 to active.
- 🇮🇳India ravi kant Jaipur
ravi kant → changed the visibility of the branch 3389509 to hidden.
- Status changed to Needs review
about 1 year ago 10:05am 21 December 2023 - 🇮🇳India ravi kant Jaipur
I have resolved pipeline failed issue.
The MR is ready to merge now. - Status changed to Needs work
about 1 year ago 10:47am 27 December 2023 - 🇮🇳India djsagar
Hi @ravi kant,
Not able to apply MR !35,
Kindly check.Thanks!
- Status changed to Needs review
about 1 year ago 11:25am 28 December 2023 - 🇮🇳India ravi kant Jaipur
@djsagar
I updated PR and tested as apply the patch as following.
curl https://git.drupalcode.org/project/gin/-/merge_requests/351.patch | git apply -v
- Assigned to Kanchan Bhogade
- Issue was unassigned.
- Status changed to RTBC
about 1 year ago 12:55pm 28 December 2023 - 🇮🇳India Kanchan Bhogade
Hi, I tested MR !351 on Drupal version 10.0 for the GIn Theme
The patch was applied successfully
Testing Steps:- Set up the Drupal 10 site.
- Set the Gin theme as a default theme
- Go to Article content type -> Manage Fields -> Edit the image field and go to the Field Settings tab.
- Allow a number of values more than one or select unlimited and save the configuration.
- Click on add content type and add more than two images.
- Apply the shared patch & reverify the results.
The patch was applied successfully, and the Drag image icon and image field alignment fixed for the Gin theme.
Moving to RTBCBefore and After patch Screenshots are attached for reference
-
saschaeggi →
committed 0730cc8b on 8.x-3.x authored by
chrisck →
Resolve #3389509 "Drag handle multiple file"
-
saschaeggi →
committed 0730cc8b on 8.x-3.x authored by
chrisck →
- Status changed to Fixed
10 months ago 9:14pm 20 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.