Remove unused variables [$resource,$key] from ResourceTest

foreach ($manager->getDefinitions() as $resource => $definition) { foreach ($definition['uri_paths'] as $key => $uri_path) { $this->assertStringNotContainsString('//', $uri_path, 'The resource URI path does not have duplicate slashes.'); } }

Comments & Activities

Issue created by @anmolgoyal74
First commit to issue fork.
@samaraof opened merge request.
Comment over 1 year ago →
samaraof
Hi , I'm opened a pull request for this change. Tests it's ok :)
Comment over 1 year ago →
🇮🇳India Nikhil_110
Remove unused variables for Patch Drupal 10.x
Status changed to Needs review over 1 year ago3:34pm 11 February 2023
Comment over 1 year ago →
🇮🇳India sourabhjain
@nikhil PR Is already created so we don't need patch now.
Moving it to needs review.
Status changed to RTBC over 1 year ago10:16pm 18 February 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Appears #5 is the same as the MR so removing credit for that as a reupload.

Change in MR 3390 seems fine.
Status changed to Closed: duplicate over 1 year ago9:44am 20 February 2023
Comment over 1 year ago →
🇳🇿New Zealand quietone New Zealand
Thanks for working to improve Drupal core.

The changes here are coding standard changes which are done by rule and not by individual file. That will prevent future re-introductions of this problem. Coding standard fixes are being coordinated at 📌 [Meta] Fix coding standards in core Active . For this particular issue, the work is being done in 📌 Use sniff DrupalPractice.CodeAnalysis.VariableAnalysis on */tests/* Needs work . The changes here are already in the patch over there.

I'll make this a duplicate and move credit for the MR.

Remove unused variables [$resource,$key] from ResourceTest

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments & Activities