Use sniff DrupalPractice.CodeAnalysis.VariableAnalysis on */tests/*

Closed 📌 Remove unused variables [$resource,$key] from ResourceTest Closed: duplicate as a duplicate, adding credit.

Adding parent.

quietone → credited samaraof@ciandt.com → .

Discussed this longwave and they suggested a different parent. I am changing the parent now. I will add a comment to the previous parent since this is using a sniff.

Change parent to the meta implementing this sniff.

While working on this I found two tests that seem to have lost test coverage from earlier changes. Because of that and the size of this was growing I decided to split this up.

There is an error on core/modules/views/tests/src/Unit/Controller/ViewAjaxControllerTest.php

Drupal\Tests\views\Unit\Controller\ViewAjaxControllerTest::testAjaxView
TypeError: Drupal\Tests\views\Unit\Controller\ViewAjaxControllerTest::setupValidMocks(): Return value must be of type array, MockObject_ViewExecutable_903e6638 returned

core/modules/views/tests/src/Unit/Controller/ViewAjaxControllerTest.php:435
core/modules/views/tests/src/Unit/Controller/ViewAjaxControllerTest.php:197

because setupValidMocks has a return type hint of array but it does not return an array. It returns a mock. Changed in 📌 Add array return typehints to protected test helper methods Needs review

Appears to be a pretty valid open question.

When I opened the current implementation of core/modules/field/tests/src/Unit/Plugin/migrate/process/d6/FieldInstanceSettingsTest.php I actually see that $migration is flagged as an unused variable

Believe feedback has been addressed for this one.

NW for some additional removals and also a question about the configuration file.

Thanks for the reviews.

Removed the suggestions, had to re-run tests 2 times for random failures.

Committed 0635e0d and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.