Jaipur, Rajasthsan
Account created on 12 September 2023, over 1 year ago
#

Merge Requests

More

Recent comments

gaurav gupta Jaipur, Rajasthsan

@glottus , we are getting this error because the migrate_google_sheets_example_setup module is trying to install a block configuration that depends on the Bartik theme, which is no longer available in Drupal 11.
There are two ways we can fix this :

  1. Change the bartik theme to any other theme
  2. Moving the block configuration from config/install to config/optional

I am doing the 2 option so that we don't get this error.

gaurav gupta Jaipur, Rajasthsan

I can work on it , if maintainer want the changes .
@chaitanyadessai, Please let me know.
Thanks.

gaurav gupta Jaipur, Rajasthsan

Hello @astonvictor,
I'm encountering an issue while installing the module (see attached screenshot). The problem arises because the module follows PSR-0 coding standards, whereas Drupal 8 follows PSR-4 coding standards.
Should I address this issue within the same ticket, or would you prefer that I create a new issue for it?
Please let me know.
Thanks, Gaurav

gaurav gupta Jaipur, Rajasthsan

@nathanhealea,
I believe this is the intended workflow by the maintainers. However, if they want to make any changes, I am happy to work on them.

gaurav gupta Jaipur, Rajasthsan

The changes has been done as per the suggestions in #13.
Moving it to RTBC.
Thanks.

gaurav gupta Jaipur, Rajasthsan

Hello ,
i have checked the MR and and all phpcs issues are resolved but there are some phpstan issues left which we can create new issue for that and gitlab pipeline is also green for phpcs.
Screenshots attatched.
Thanks.

gaurav gupta Jaipur, Rajasthsan

Hello,
i have tested the MR before and after .
All the coding standards issues has been solved.
Thanks.

gaurav gupta Jaipur, Rajasthsan

Hello,
I have tested the patch and all issues has been solved.
Thanks.

gaurav gupta Jaipur, Rajasthsan

Hello,
I have reviewed the merge request, and all PHPCS issues have been resolved. The only remaining issues are related to Drupal dependency injection, which fall under PHPStan's scope. We can create a separate issue to address those.
Thank you.

gaurav gupta Jaipur, Rajasthsan

Hello ,
i have tested the MR and the issue has been solved.
Thanks.

gaurav gupta Jaipur, Rajasthsan

@fjgarlin,
Thanks for the suggestions.
Please check.
Thanks.

gaurav gupta Jaipur, Rajasthsan

@pearls , Can you please write steps to reproduce . I am not getting any error.
Thanks.

gaurav gupta Jaipur, Rajasthsan

As far as I understand, you want two delimiters for the multiple email addresses: commas and new lines. Am I right? However, won't it be confusing to have two delimiters? According to me, it could cause confusion.

gaurav gupta Jaipur, Rajasthsan

@fjgarlin @leymannx Thanks for pointing out my mistake , I have revert the last commit and adressed the unresolved thread and made changes accordingly . Please check . Thanks

gaurav gupta Jaipur, Rajasthsan

gaurav gupta changed the visibility of the branch 3489931-multiple-recipients-email to active.

gaurav gupta Jaipur, Rajasthsan

gaurav gupta changed the visibility of the branch 3489931-multiple-recipients-email to hidden.

gaurav gupta Jaipur, Rajasthsan

Made the changes.
Please check.
Thanks.

gaurav gupta Jaipur, Rajasthsan

@fjgarlin
Assigning myself the ticket , if you want i can work on it as per comment #7 Allow multiple email recipients Active .
Please let me know. Thanks.

gaurav gupta Jaipur, Rajasthsan

Hi Gergo,
It is working as expected. Drupal does not accept special characters in machine names and replaces them with underscores if they appear between letters and numbers. Please find the attached screenshot for reference.
Thanks.

gaurav gupta Jaipur, Rajasthsan

@dudeweb
Can you please add steps to reproduce the error i am unable to reproduce a error.

gaurav gupta Jaipur, Rajasthsan

Hello,
I have reviewed the issue and it is working as expected.
Thanks

gaurav gupta Jaipur, Rajasthsan

@anybody
i have reproduce the issue and check the js code with old version and can see significant changes , so i have checked why we did this changes in first place and came across this two issues: https://www.drupal.org/project/extlink/issues/3476565 🐛 Remove wrapping the last word in extlink span. Needs review
https://www.drupal.org/project/extlink/issues/3487095 New option "Wrap only text-like links." Active ,
they are already working on this issue.
if there is anything else you want to do solve this error. Please let me know.
Thanks.

gaurav gupta Jaipur, Rajasthsan

@tim-diels
Can you please tell do i need to solve those errors and if yes how can i reproduce it?

gaurav gupta Jaipur, Rajasthsan

@tim-diels
Can you please tell how are you getting this error.
I am getting this error only.

gaurav gupta Jaipur, Rajasthsan

@sourabhsisodia_ The issue here is the duplication of machine name which causes error , after using MR it won't cause any issue.
If we were to use ajax then we have to change so many things in order to make it work which i don't think will be right .
Moving it back to the review state.

gaurav gupta Jaipur, Rajasthsan

Hello all ,
Applied MR!39 and patch #8 and was getting the error so add a commit in MR!39.
Please check.

gaurav gupta Jaipur, Rajasthsan

Since we are unable to reproduce this issue , so closing this.
Thanks.

gaurav gupta Jaipur, Rajasthsan

Hello @minnur
Thanks for the quick merge but i can see you didnot provide the credit for the issue.
It would be great if you could provide us the credits.
Thanks.

gaurav gupta Jaipur, Rajasthsan

Hello @poker10
i have gone through the issue and were able to reproduce it
but i think it would be better if we "add a form validation message, to check existence of email for a valid username" instead of showing the existing generic message.
My solution is to add a validation UserPasswordForm.php

 if (empty($account->getEmail())) {
        $form_state->setErrorByName('name', $this->t('The account does not have a valid email address.'));
        return;
      }

I think it will be a good approach since it is breaking the drupal site instead of any security issues of what we see here
https://www.drupal.org/project/drupal/issues/1521996

gaurav gupta Jaipur, Rajasthsan

Hi I have tested MR 1 in drupal 11 version.
Modules installed successfully without any issue.
Screenshots attatched.
Thanks.

gaurav gupta Jaipur, Rajasthsan

Hello all
i have tested the MR in my local and check the config form and there are no issue in upgrade status.
Moving it to RTBC.
Thanks.

gaurav gupta Jaipur, Rajasthsan

gaurav gupta made their first commit to this issue’s fork.

gaurav gupta Jaipur, Rajasthsan

Hello,
I have reviewed the issue and it is working as expected.
Thanks.

gaurav gupta Jaipur, Rajasthsan

Hello @samcohen,
Tried to reproduce the error but couldnot find any issue associated with content type selection ignores.
Please check on fresh site and let me know if issue persists.
Thanks.

gaurav gupta Jaipur, Rajasthsan

@samcohen
I am unable to reproduce the error.
Can you please check and verify.
Thanks.

gaurav gupta Jaipur, Rajasthsan

@adaragao
it wont change the machine name like this if you will save it then it will made the change

gaurav gupta Jaipur, Rajasthsan

gaurav gupta made their first commit to this issue’s fork.

gaurav gupta Jaipur, Rajasthsan

Hello @rleroux,
i am using drupal 10.3.1 and in my local it is working alright !!
Can you please check and let me know if the issue persists

gaurav gupta Jaipur, Rajasthsan

Gaurav Gupta changed the visibility of the branch automatic_updates-3406122-3406122-configure-link to hidden.

gaurav gupta Jaipur, Rajasthsan

Gaurav Gupta changed the visibility of the branch 3406122-add-configure-link to hidden.

gaurav gupta Jaipur, Rajasthsan

Hello @Liliplanet
You need to change formatter in manage display of content type then you can see caption also.

gaurav gupta Jaipur, Rajasthsan

Hello @kopeboy
The issue has already been fixed in this issue: 📌 Fix jquer.ui dependency Fixed and it is in development version.
Closing the issue.
Thanks

gaurav gupta Jaipur, Rajasthsan

Hello ,
i have solved the remaining issues.
Please check .
Thanks.

gaurav gupta Jaipur, Rajasthsan

Hello @nigelwhite,
It seems this issue has already been solved in the latest development version.
Please check.
Thanks.

gaurav gupta Jaipur, Rajasthsan

Gaurav Gupta changed the visibility of the branch 3460578-use-of-self to hidden.

gaurav gupta Jaipur, Rajasthsan

Hello @riazsaid15
I have installed the module and not facing any such error.
My site credentials: Drupal version: 10.3.1 , PHP: 8.1.28.
Please check it in a fresh site if the issue still arise and provide steps to reproduce.
Thanks.

gaurav gupta Jaipur, Rajasthsan

@carolpettirossi,
I have installed the module and not facing any such error.
My site credentials: Drupal version: 10.3.1 , PHP: 8.1.28.
Please check it in a fresh site if the issue still arise and provide steps to reproduce.
Thanks.

gaurav gupta Jaipur, Rajasthsan

Hi @nigelwhite,
I tried to reproduce the error but unable to do so , I even check with upgrade status but there are no issue in it also.
Please check and let me know if the issue persisits.
Thanks

gaurav gupta Jaipur, Rajasthsan

Gaurav Gupta made their first commit to this issue’s fork.

Production build 0.71.5 2024