- Issue created by @Liam Morland
- πΊπΈUnited States mark_fullmer Tucson
As a maintainer, I agree that this suggestion makes a lot of sense. Perhaps the best thing to do is to move that warning to the URL Embed configuration section, instead of the generic site warnings.
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
That makes sense to me. If a site builder sees that Facebook embeds do not work, they might visit the
url_embed
config page to find out why and see the warning there but the warning does not appear on the main status page. - Merge request !19Issue #3487570: Allow disabling Facebook warning. β (Merged) created by gaurav gupta
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
I think it would make sense that if
facebook_app_id
orfacebook_app_secret
are provided that theurl_embed_debug_facebook_access_token()
check still runs. In other words, no warning if they are not configured but if they are there, they must be valid. Other than that, reading the code, it looks good. -
mark_fullmer β
committed 4029f85d on 3.x authored by
gaurav gupta β
Issue #3487570: Allow disabling Facebook warning
-
mark_fullmer β
committed 4029f85d on 3.x authored by
gaurav gupta β