- Issue created by @prashant.c
- First commit to issue fork.
- Merge request !989Issue #3356804 by phenaproxima: Flag a warning during status check if the... → (Closed) created by sandipta
- Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7last update
about 1 year ago Not currently mergeable. - last update
about 1 year ago Patch Failed to Apply - Status changed to Needs work
about 1 year ago 3:13pm 8 December 2023 - 🇺🇸United States phenaproxima Massachusetts
Looks like this needs a reroll.
- gaurav gupta Jaipur, Rajasthsan
Gaurav Gupta → changed the visibility of the branch 3406122-add-configure-link to active.
- Status changed to Needs review
9 months ago 5:40am 5 April 2024 - last update
9 months ago Custom Commands Failed - Merge request !10533406122-configure-link: Added configure link for module. → (Closed) created by gaurav gupta
- 🇮🇳India Vivek Panicker Kolkata
Code looks good.
Also requirements are fulfilled.
Hence moving to RTBC. - Status changed to RTBC
9 months ago 8:50am 6 April 2024 - Status changed to Needs review
8 months ago 1:00pm 10 April 2024 - 🇺🇸United States phenaproxima Massachusetts
I'm not sure this patch makes sense as-is. The configure link for Automatic Updates Extensions isn't really a configuration page, so...why is it there? Can you explain the rationale for pointing it to that specific route?
- gaurav gupta Jaipur, Rajasthsan
@phenaproxima
Yes, I agree since Automatic Updates Extensions does not have any configuration form we can skip this.
Made the changes.
Thanks - Status changed to Needs work
6 months ago 3:54pm 12 June 2024 - 🇺🇸United States phenaproxima Massachusetts
Tests appear to be failing...?
- gaurav gupta Jaipur, Rajasthsan
@phenaproxima
I am not sure if i have made changes that made pipeline failed.
All i have done is solve conflicts and revert some changes./
Thanks. - 🇩🇪Germany Anybody Porta Westfalica
Tests are failing because this targets the wrong branch. I'll fix that and update the fork.
- Merge request !1089Issue #3406122-configure-link: Added configure link for module. → (Open) created by gaurav gupta
- gaurav gupta Jaipur, Rajasthsan
Gaurav Gupta → changed the visibility of the branch 3406122-add-configure-link to hidden.
- gaurav gupta Jaipur, Rajasthsan
Gaurav Gupta → changed the visibility of the branch automatic_updates-3406122-3406122-configure-link to hidden.
- 🇮🇳India prashant.c Dharamshala
Rebased with
3.1.xLets see the tests pass or not. - 🇮🇳India prashant.c Dharamshala
Prashant.c → changed the visibility of the branch 3406122-configure to hidden.
- Status changed to Needs review
5 months ago 4:51pm 2 August 2024 - 🇮🇳India prashant.c Dharamshala
There were a lot of out-of-scope changes in the previously raised MRs, raised a new one, and made others hidden. Once the tests pass we can change the issue status to NR
- Status changed to Needs work
5 months ago 4:51pm 2 August 2024 - Status changed to Needs review
4 months ago 5:52am 4 September 2024 - Status changed to RTBC
4 months ago 8:33am 4 September 2024 - 🇮🇳India Tirupati_Singh
Hi, I've applied the provided MR as a patch and it applied cleanly with no errors. Before applying patch there was no Configuration link for the module on the Extend page
/admin/modules. On applying the patch, module configuration link is now added on the Extend page andadmin/reports/updates/settingspage opens when clicking on the Configure link. I've attached the before and after screenshots for reference.Thanks!
- 🇮🇳India sourav_paul Kolkata
Yeah, MR !1090 works for me as well.
It attached a configure link to the module on the extend page.RTBC+1
-
phenaproxima →
committed b71155ee on 3.1.x authored by
prashant.c →
Issue #3406122 by gaurav gupta, sandipta, prashant.c, phenaproxima: Add...
-
phenaproxima →
committed b71155ee on 3.1.x authored by
prashant.c →
- Status changed to Fixed
4 months ago 1:29pm 4 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.