Contrib.social

Automated Drupal 11 compatibility fixes for quick_node_clone

Open on Drupal.org →
Created on 24 March 2024, 9 months ago
Updated 17 May 2024, 7 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Needs review

Version

1.18

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • Comment 9 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

    Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

    The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-127659

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.9
    3. palantirnet/drupal-rector: 0.20.1
  • Merge request !26Automated Project Update Bot fixes → (Merged) created by project update bot
  • Pipeline finished with Success
    9 months ago
    Total: 190s
    #127891
  • Pipeline finished with Success
    9 months ago
    Total: 189s
    #127892
  • First commit to issue fork.
  • Pipeline finished with Success
    7 months ago
    Total: 189s
    #174738
  • Comment 7 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-188815

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.2
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.2
  • Pipeline finished with Failed
    7 months ago
    #189164
  • Assigned to sourav_paul
  • Comment 4 months ago →
    🇮🇳India sourav_paul Kolkata
  • Pipeline finished with Failed
    4 months ago
    Total: 215s
    #261620
  • Issue was unassigned.
  • Status changed to RTBC 4 months ago
  • Comment 4 months ago →
    🇮🇳India sourav_paul Kolkata

    I've tested the patch in D11, and the functionality was working but when I tried to open the config form it encountered an error due to a missing argument in the parent class ConfigFormBase of "TypedConfigManagerInterface". I've solved the issue in this MR...

    It is working now in d11..

  • Assigned to Grevil
  • Status changed to Needs work 4 months ago
  • Comment 4 months ago →
    🇩🇪Germany Grevil
  • Issue was unassigned.
  • Status changed to Postponed 4 months ago
  • Comment 4 months ago →
    🇩🇪Germany Grevil

    The parent module "group" is not yet D11 ready.

    POSTPONED on 📌 Automated Drupal 11 compatibility fixes for group Needs review .

  • Pipeline finished with Failed
    4 months ago
    Total: 275s
    #265956
  • Comment 3 months ago →
    🇨🇦Canada deviantintegral

    Given how many module users aren't using group, and from what I can tell group is only used for an integration test, can we make it so that test only runs on Drupal 10, and is skipped on Drupal 11?

  • Status changed to Active 3 months ago
  • Comment 3 months ago →
    🇺🇸United States bluegeek9
  • Comment 3 months ago →
    🇩🇪Germany Grevil

    Not for the long term. We should add "group" as a dev dependency in the composer.json and as a test_dependency in the info.yml instead of a "real" dependency.

    Right now, we could opt out of testing phpunit-next-major, which will temporarily let the tests succeed, but once D11 becomes current major, we get the same failure. Although this could take a while, so yea, why not.

  • Comment 3 months ago →
    🇩🇪Germany Grevil

    grevil → changed the visibility of the branch 3434076-automated-drupal-11 to hidden.

  • Comment 3 months ago →
    🇩🇪Germany Grevil

    Sorry, we already require it as a dev dependency. I adjusted the .gitlab-ci.yml.

    I removed forcibly making the pipeline fail if phpcs / phpstan fail. Let's see, what the pipeline says now.

  • Pipeline finished with Success
    3 months ago
    Total: 185s
    #296838
  • Comment 3 months ago →
    🇩🇪Germany Grevil

    Alright, pipeline is green now! All fixed!

  • Pipeline finished with Success
    3 months ago
    Total: 245s
    #296938
  • Pipeline finished with Success
    3 months ago
    Total: 187s
    #300741
  • Comment 2 months ago →
    gaurav gupta Jaipur, Rajasthsan

    Hello all
    i have tested the MR in my local and check the config form and there are no issue in upgrade status.
    Moving it to RTBC.
    Thanks.

  • Pipeline finished with Failed
    about 2 months ago
    Total: 236s
    #324388
  • Pipeline finished with Failed
    about 2 months ago
    Total: 209s
    #324431
  • Pipeline finished with Failed
    about 2 months ago
    Total: 210s
    #324441
  • Pipeline finished with Success
    about 2 months ago
    Total: 208s
    #324450
  • Comment about 2 months ago →
    🇺🇸United States bluegeek9

    I removed the use of randomGenerator in Functional tests. RandomGenerator is a trait used in Kernel tests. It looks to no longer be part of functional tests in Drupal 11.

  • Pipeline finished with Skipped
    about 2 months ago
    #329199
  • Comment about 2 months ago →
    System Message
  • Comment about 2 months ago →
    🇺🇸United States bluegeek9
  • Comment about 2 months ago →
    🇺🇸United States bluegeek9

    I intend to make a new release this week.

  • Comment about 2 months ago →
    🇩🇪Germany Grevil

    Great stuff!!

    Thanks, @bluegeek9 🎉

  • Status changed to Fixed about 1 month ago
  • Comment about 1 month ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024