Fix the issues reported by phpcs

Fixed Some PHPCS issues.

-    return condition.settings.smart_cdn.value ?? null;
+    return condition.settings.smart_cdn.value ? ? NULL;

condition.settings.smart_cdn.value ?? null is not a valid JavaScript expression (since JavaScript does not have a null coalescing operator); adding a space does not make it valid.
No warnings/errors have been shown in the report for that file.

     // Output current header data.
     $form['header_output'] = [
       '#markup' => '<h2>Current Headers</h1>
-                              <div>Audience: ' . $audience_header . '</div>
-                              <div>Interest: ' . $interest_header . '</div>',
+                                    <div>Audience: ' . $audience_header . '</div>
+                                    <div>Interest: ' . $interest_header . '</div>',
     ];

The indentation of those lines is still wrong, since the indentation must be increased of two spaces each time.

+   * Multi-dimensional array of decisions to be evaluated,keyed by condition.
+   *
+   * @var array
+   */
+  protected $decisions;

After a comma, there must be a space.

+  /**
+   * Decision evaluator object.
+   *
+   * @var object
+   */
+  protected $evaluator;

The description is missing a definite article.

+  /**
+   * Implements setUp().
+   */
+  protected function setUp(): void {

Method descriptions must not start with Implements nor repeat the method name.

+  /**
+   * {@inheritdoc}
+   */
+  protected function _evaluateDecisions($key): void {

{@inheritdoc} must be used for inherited methods or methods defined in an interface.

+  /**
+   * Array of ResponseEvent objects keyed by test type.
+   *
+   * @var object
+   */
+  protected $events;

Since that property is described as an array, its type cannot be object.

The patch is changing files without any reported warning/error. Either the report is updated, or the patch only changes the files shown in the report.

DI issues still needs to be addressed.

+  /**
+   * Sets the test up.
+   */
+  protected function setUp(): void {
+    parent::setUp();
+    $this->attachSettings();
+  }

Since that is an inherited method, the documentation comment must be different.

+  /**
+   * {@inheritdoc}
+   */
+  protected function evaluateDecisions($key): void {

That is not an inherited method. Its documentation comment must be different.

-        // Loop through decisions by $key.
-        foreach ($this->decisions[$key] as $decision) {
-            // Get segment id from decision evaluation.
-            $segment_id = $this->evaluator->evaluate($decision);
-            $this->assertEquals('segmentC', $segment_id);
-        }
+    // Loop through decisions by $key.
+    foreach ($this->decisions[$key] as $decision) {
+      // Get segment id from decision evaluation.
+      $segment_id = $this->evaluator->evaluate($decision);
+      $this->assertEquals('segmentC', $segment_id);
     }

That comment is not necessary, since it describes something already clear from the code.

+  /**
+   * Sets the test up.
+   */
+  protected function setUp(): void {

The documentation comment for inherited methods is different.

+  /**
+   * Test that vary header is empty when there are no cache tags.
+   */
+  public function testVaryHeadersNoTags(): void {

The verb in the description must use the third person singular (I test, you test, he/she/it …).

+  /**
+   * {@inheritdoc}
+   */
+  protected function getAlteredHeaders($key) {

That is not an inherited method; its documentation comment must be different.

+  /**
+   * Implements tearDown().
+   */
+  protected function tearDown(): void {

The description for a method must not start with Implements nor repeat the method name. That is an inherited method and its documentation comment must be different.

Updated MR based on #9. Please review.

Hi,

I'm still seeing PHPCS errors after applying the latest Merge to the Smart Content CDN module with version 1.0.x-dev and with Drupal core version 9.5.8.

Moving this to Needs work for now.
Kindly refer to the attached screenshots, please.

Please review.

Looks like this is taking action on JS too, which is likely unintentional...

diff --git a/js/condition.cdn.js b/js/condition.cdn.js
index 1fca7b4..92ee348 100644
--- a/js/condition.cdn.js
+++ b/js/condition.cdn.js
@@ -11,7 +11,7 @@
 
   // Handle Smart CDN conditions based on settings.
   Drupal.smartContent.plugin.Field['smart_cdn'] = function (condition) {
-    return condition.settings.smart_cdn.value ?? null;
+    return condition.settings.smart_cdn.value ? ? NULL;
   }
 
 })(Drupal);
diff --git a/js/condition_type.cdn.js b/js/condition_type.cdn.js
index 39d22bb..64ea32a 100644
--- a/js/condition_type.cdn.js
+++ b/js/condition_type.cdn.js
@@ -15,12 +15,12 @@
       for(var i = 0; i < value.length; i++) {
         // Check array value with value set in Segment condition.
         if (value[i] === condition.settings['value']) {
-          return true;
+          return TRUE;
         }
       }
     }
 
-    return false;
+    return FALSE;
   };
 
-})(Drupal);
\ No newline at end of file
+})(Drupal);

apaderno → changed the visibility of the branch 3359899-fix-the-issues to hidden.

kelly.m.jacobs → made their first commit to this issue’s fork.