Change machine name while writing the label

gaurav gupta → made their first commit to this issue’s fork.

Tested MR 7 on Drupal 10.3.2, PHP 8.3.9.

Doesn't work.

@adaragao Please check again

Still not working. I think this is a bit weird.

Drupal 10.3.3, still have this as a core module, but if I try to apply the patch in core, gives me an error.

It only apply the patch as if it is the "action" module, and yet composer.json, doesn't have it listed as an independent module, and if I try "composer require drupal/action" is says that 0.2.1 is installed.

Is it really applying the patch ?

Still not working. I think this is a bit weird.

Drupal 10.3.3, still have this as a core module, but if I try to apply the patch in core, gives me an error.

It only apply the patch as if it is the "action" module, and yet composer.json, doesn't have it listed as an independent module, and if I try "composer require drupal/action" is says that 0.2.1 is installed.

Is it really applying the patch ?

@adaragao
it wont change the machine name like this if you will save it then it will made the change

I have tested MR !7 and it works fine and as expected changing machine name , according to label .
Some Recommendation it will be better if @gaurav gupta , you use ajax to change machine name .
Attaching video for reference . RTBC++

@sourabhsisodia_ The issue here is the duplication of machine name which causes error , after using MR it won't cause any issue.
If we were to use ajax then we have to change so many things in order to make it work which i don't think will be right .
Moving it back to the review state.

Then @gaurav gupta it works good . I have added comment #10 attaching video for reference . RTBC++.

I merged 🐛 PHP 8.4 implicit nullable deprecation Needs work

So now tests should be fixed

Looks the failure related to test expectations for local tabs

but there's new validation method which needs extensive testing to get all BC breaks