TypeError: Drupal\ai_translate\Controller\AiTranslateController::translateSingleText(): Argument #1 ($singleText) must be of type array

The website encountered an unexpected error. Try again later. TypeError: Drupal\ai_translate\Controller\AiTranslateController::translateSingleText(): Argument #1 ($singleText) must be of type array, string given, called in /var/www/html/web/modules/contrib/auto_translation/src/Utility.php on line 218 in Drupal\ai_translate\Controller\AiTranslateController->translateSingleText() (line 133 of modules/contrib/ai/modules/ai_translate/src/Controller/AiTranslateController.php). Drupal\auto_translation\Utility->drupalAiTranslateApiCall() (Line: 129) Drupal\auto_translation\Utility->translate() (Line: 448) Drupal\auto_translation\Utility->formTranslate() (Line: 39) auto_translation_form_node_form_alter() (Line: 459) Drupal\Core\Extension\ModuleHandler->alter() (Line: 833) Drupal\Core\Form\FormBuilder->prepareForm() (Line: 249) Drupal\autosave_form\Form\AutosaveFormBuilder->prepareForm() (Line: 280) Drupal\Core\Form\FormBuilder->buildForm() (Line: 97) Drupal\autosave_form\Form\AutosaveFormBuilder->buildForm() (Line: 48) Drupal\Core\Entity\EntityFormBuilder->getForm() (Line: 413) Drupal\content_translation\Controller\ContentTranslationController->add() call_user_func_array() (Line: 123) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 593) Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 183) Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76) Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53) Drupal\Core\StackMiddleware\Session->handle() (Line: 48) Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28) Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32) Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 116) Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 90) Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48) Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51) Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36) Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51) Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 709) Drupal\Core\DrupalKernel->handle() (Line: 19)

Comments & Activities

Issue created by @Vivek Panicker
Merge request !3Issue #3509171: Remove call to controller and instead call service. → (Merged) created by Vivek Panicker
Comment 2 months ago →
🇮🇳India Vivek Panicker Kolkata
Pipeline finished with Success
2 months ago
Total: 143s
#434753
Comment 2 months ago →
🇮🇳India Vivek Panicker Kolkata
Even after doing this, one more issue remains.
That is if a formatted text field is sent for translation, then in the translated content, the translated text contains the HTML markups unescaped, i.e. we can see the markup.
We should try to resolve this also in a separate bug.
Comment 2 months ago →
System Message

vivek panicker → committed 00ee5c38 on 1.0.x
Issue #3509171: Remove call to controller and instead call service.
Comment 2 months ago →
🇮🇹Italy bigbabert Milano, Italy
Great thanks also for the final fix and code best practice improvement, i'll create new release with this!
Comment 2 months ago →
🇮🇹Italy bigbabert Milano, Italy
Comment 2 months ago →
🇮🇹Italy bigbabert Milano, Italy
Comment 2 months ago →
🇮🇹Italy bigbabert Milano, Italy
Comment 2 months ago →
🇮🇳India Vivek Panicker Kolkata
Happy to help!
I tested v1.3.1 and the issue is now resolved. :)
Comment 2 months ago →
🇮🇹Italy bigbabert Milano, Italy
Hi @vivek,

i think that this weekend i'll re-work that one since the idea of the module is to not be dependent by ai module or other module not enabled on the majority of websites (eg. node). Now with this change if someone want to use Google API or Liber Translate without installing drupal ai the auto_translation module will crash since doesn't has the ai_translate dependency declaration in it's .info.

Thanks again,

BR
Comment 2 months ago →
🇮🇳India Vivek Panicker Kolkata
I have a few ideas for this one then.

We can have a parent module with the base implementation, then a submodule for each of the different services we are supporting like 1 for AI module, 1 for Google and so on.
So if tomorrow someone wants to add a new translation service, they can easily do that from a custom or a third party module.
Comment 2 months ago →
🇮🇹Italy bigbabert Milano, Italy
Hi vivek,

i would not spread submodules, unless we not manage to enable it from the ui when switching provider, this would be great i think.

Thanks
Comment 2 months ago →
🇮🇳India Vivek Panicker Kolkata
I guess the provider options would only appear if the modules are enabled, not the other way around.
In the config form we can ask the user to enable any of the submodules to access a provider.
We can always provide a default provider if we want, so that on enabling itself a provider also appears.

TypeError: Drupal\ai_translate\Controller\AiTranslateController::translateSingleText(): Argument #1 ($singleText) must be of type array

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!3TypeError: Drupal\ai_translate\Controller\AiTranslateController::translateSingleText(): Argument #1 ($singleText) must be of type array
Merged

Comments & Activities

TypeError: Drupal\ai_translate\Controller\AiTranslateController::translateSingleText(): Argument #1 ($singleText) must be of type array

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!3TypeError: Drupal\ai_translate\Controller\AiTranslateController::translateSingleText(): Argument #1 ($singleText) must be of type arrayMerged

Comments & Activities

!3TypeError: Drupal\ai_translate\Controller\AiTranslateController::translateSingleText(): Argument #1 ($singleText) must be of type array
Merged