@sourabhjain
Thank you for the refactoring.
@yas
I made a merge request, please review it.
@yas
Thank you for the review.
I applied your suggestion. Please check again.
nakamurarts → created an issue.
nakamurarts → created an issue.
nakamurarts → created an issue.
nakamurarts → created an issue.
nakamurarts → created an issue.
nakamurarts → created an issue.
@yas
Please review the code, thank you.
nakamurarts → created an issue.
@yas
Thank you for the review.
I changed `let` to `const`. Please review again.
nakamurarts → created an issue.
Only the addition of BDD test cases was performed, as the appropriate messages are already displayed now.
Also, fixed the permission name ('view own openstack flavor')
nakamurarts → created an issue.
@yas
I have corrected it as you suggested.
Please review it again, thank you.
@sekinet
Thank you for the review. Please check again as I have modified it according to your suggestion.
Simplified health-check process.
We assume that the endpoint for this health check is protected by layers other than Drupal.
@yas
@ sekinet
Thank you all for your reviews.
I've corrected the parts you mentioned, so please check again.
nakamurarts → created an issue.
@yas
Thank you for review.
Following a suggestion from a previous meeting, I have added a test case to `K8s-ATDD-01-01-ReadNoUserResources.feature` that checks for message changes due to user roles.
nakamurarts → created an issue.
@yas
Thank you for the review.
Sorry for the delayed response. I have made the same correction in other parts.
nakamurarts → created an issue.
@yas
Thank you for your review.
Please check back as I have revised it according to your suggestion.
nakamurarts → created an issue.
@sekinet
Thank you for your review and suggestions.
I have made the corrections according to your suggestions,
could you please check again?
@sekinet
Thank you for reviewing.
I corrected according to your suggestion. Please check.
nakamurarts → created an issue.
@yas
Thank you for your review. I fixed the coding standard errors.
@yas @sekinet
Thank you all for your reviews.
I added tests based on the suggestion.
- https://git.drupalcode.org/project/cloud/-/merge_requests/1869/diffs?com...
- https://git.drupalcode.org/project/cloud/-/merge_requests/1869/diffs?com...
Please review, thank you.
nakamurarts → created an issue.
@yas
Thank you for your review.
I have modified the code according to your suggestion.
Also, where not referred to but considered necessary, `? : []` was added.
Clone from https://www.drupal.org/project/cloud/issues/3324909 📌 Add a BDD test suite for OpenStack floating IP (Associate and Disassociate) Closed: outdated
nakamurarts → created an issue.
Slight modification (sorting roles alphabetically) ...
I added the permission to cloud_admin as default (just added a line ...)
@yas
Could you please review the patch?
nakamurarts → created an issue.
@yas
Thank you for the review, I have responded to your comment.
nakamurarts → created an issue.
After a long time, I've finally completed the correction for the BDD tests.
Please review, thank you.
@yas @baldwinlouie
Thank you all for your reviews.
nakamurarts → created an issue.
@yas @baldwinlouie
Thank you all for the reviews.
I refactored the field name `cloud` to `cloudService` (and the constructor argument `cloud` to `cloud_service`).
@sekinet
Thank you for your review.
That has been fixed and there are no warnings now.
There are still warnings in 4 files, all related to unused variables (or functions).
However, these appear to be intentional and I think do not need to be removed.
FILE: modules/tenants/openstack_provider/src/Service/OpenStackProviderService.php
---------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
---------------------------------------------------------------------------------
557 | WARNING | Unused private method generateStackName()
573 | WARNING | Unused private method generateStackPrefix()
607 | WARNING | Unused private method generateBearerToken()
---------------------------------------------------------------------------------
FILE: modules/tenants/openstack_provider/tenant_project.page.inc
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
24 | WARNING | Unused variable $project.
----------------------------------------------------------------------
FILE: src/Form/Config/FacadeAdminSettings.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
116 | WARNING | Unused variable $config.
----------------------------------------------------------------------
FILE: tenant.page.inc
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
24 | WARNING | Unused variable $tenant.
----------------------------------------------------------------------
nakamurarts → created an issue.
The reported warnings with cloud_orchestrator/src/Installer/Form/ModuleConfigureForm.php (line 72, 96, 103 : "\Drupal calls should be avoided in classes, use dependency injection instead") have already been resolved in 4f65e044
nakamurarts → created an issue.