Remove refresh buttons for an authenticated user

Issue created by @phyllanthus
Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Not currently mergeable.
@nakamurarts opened merge request.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
366 pass
Status changed to Needs review over 1 year ago4:04am 19 May 2023
Comment over 1 year ago →
phyllanthus
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
@nakamurarts

Thank for the patch. It looks good to me.

@baldwinlouie

What do you think?

Thanks
Status changed to RTBC over 1 year ago4:43am 19 May 2023
Comment over 1 year ago →
🇺🇸United States baldwinlouie
@nakamurarts @yas, thank you for the patch. It looks good to me.
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
@baldwinlouie

Thank you for your review.

@nakamurarts

I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.
Comment over 1 year ago →
phyllanthus
@yas @baldwinlouie

Thank you all for your reviews.
Status changed to Needs work over 1 year ago5:33am 19 May 2023
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
@hostomitm

I ran the BDD tests and found some errors regarding Refresh button. Can you please check the patch? Probably the BDD test scenarios need to be modified or the patch should be fixed. Thanks
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
366 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
366 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
366 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
366 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
44:40
41:48
Running
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
366 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
366 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
366 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
366 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
366 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
366 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
366 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
366 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
366 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
366 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
366 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
366 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
366 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
366 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
366 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
366 pass
Status changed to Needs review over 1 year ago11:41am 12 June 2023
Comment over 1 year ago →
phyllanthus
Comment over 1 year ago →
phyllanthus
After a long time, I've finally completed the correction for the BDD tests.
Please review, thank you.
Status changed to Needs work over 1 year ago8:51am 13 June 2023
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
@nakamurarts

Thank you for the patch. I have one question. Can you take a look at it? Thanks!
Status changed to Needs review over 1 year ago6:30am 14 June 2023
Comment over 1 year ago →
phyllanthus
@yas
Thank you for the review, I have responded to your comment.
Status changed to RTBC over 1 year ago8:46am 14 June 2023
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
@nakamurarts

Thank you for your explanation. I understand it. I'll merge the patch to 6.x, and close this issue as Fixed.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
366 pass
Comment over 1 year ago →
🇯🇵Japan sekinet
yas → credited sekinet → .
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
366 pass
Status changed to Fixed over 1 year ago8:48am 14 June 2023
Comment over 1 year ago →
System Message

yas → committed 33f0d99a on 6.x authored by nakamurarts →
Issue #3361362 by yas, nakamurarts, baldwinlouie, sekinet: Remove...

yas → committed 58eb2b74 on 5.x

Issue #3361362 by yas, nakamurarts, baldwinlouie, sekinet: Remove...

Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Remove refresh buttons for an authenticated user

Problem/Motivation

Comments & Activities