@yas
I changed the function we use from in_array()
to array_key_exists()
to speed up the process. Could you please review the patch? Thanks!
@yas
Thank you for providing the patch. It looks good. Thanks!
@yas
Thank you for fixing the bug. It looks good to me. Thanks!
@yas
Could you please review the patch?
sekinet → created an issue.
@yas
Could you please review the patch?
@yas
Could you please review the patch?
@yas
Could you please review the patch?
@yas
Could you please review the patch?
sekinet → created an issue.
@yas
Could you please review the patch?
sekinet → created an issue.
@yas
Could you please review the patch?
sekinet → created an issue.
sekinet → created an issue.
sekinet → created an issue.
sekinet → created an issue.
@yas
Could you please review the patch?
sekinet → created an issue.
@yas
Could you please review the patch?
@yas
Could you please review the patch?
sekinet → created an issue.
@yas
Thank you for your review. I have rebased the patch. Could you please check it?
@yas
Could you please review the patch?
sekinet → created an issue.
@yas
Could you please review the patch?
sekinet → created an issue.
@yas
Could you please review the patch?
sekinet → created an issue.
@yas
Could you please review the patch?
sekinet → created an issue.
@yas
Could you please review the patch?
@yas
Could you please review the patch?
sekinet → created an issue.
sekinet → created an issue.
@yas
Could you please review the patch?
sekinet → created an issue.
@yas
Could you please review the patch?
sekinet → created an issue.
@yas
Could you please review the patch?
sekinet → created an issue.
@yas
Could you please review the patch?
sekinet → created an issue.
@yas
Could you please review the patch?
sekinet → created an issue.
@yas
Fixed to output with I take screenshot
. Refactoring has been done accordingly. Could you please check it?
@yas
Thank you for your comment. I have fixed it as you suggested. There is an error in phpstan
, but it should go away once the PR#24 is merged. Could you please check?
@yas
Could you please review the patch?
@yas
I have also created a patch for the 5.x branch. Could you please check it?
sekinet → changed the visibility of the branch 3405430-refactor-to-native-JavaScript-from-jQuery-k8s_launch_template_source_type.js-5x to hidden.
Sorry, the above comment was an error in commenting on another Issue. Please review the patch. Thanks.
@yas @hosomitm
Thank you for providing the patch. It looks good to me. Because we don't need this JavaScript anymore.
Background.
Previously, source_type included yaml and added JavaScript to switch to the YAML tab when it was selected.
We have since refactored the source_type to remove the yaml from the source_type. However, I think we ware unable to remove this JavaScript file and the unnecessary file remained.
Thanks.
@yas @hosomitm
Thank you for providing the patch. It looks good to me. Because we don't need this JavaScript anymore.
Background.
Previously, source_type included yaml and added JavaScript to switch to the YAML tab when it was selected.
We have since refactored the source_type
to remove the yaml
from the source_type
. However, I think we ware unable to remove this JavaScript file and the unnecessary file remained.
Thanks.
@yas
Could you please review the patch?
@yas
Thank you for your comments. I have fixed them, so could you please check them?
@yas
Could you please review the patch?
@nakamiurarts @yas
The patch looks good to me. Thanks.
@yas
Could you please review the patch?
@yas
Could you please review the patch?
sekinet → created an issue.
@yas
Could you please review the patch?
@yas
Could you please review the patch?
@nakamurarts
It looks good.
@yas
What do you think? Also, could you please change my thread to resolved?
@nakamurarts
Thank you for the update. It looks good. Can you rebase the patch?
@nakamurarts
Thank you for the update. I posted a few comments, can you please check them out?
@nakamurarts
Thank you for the patch. It looks good.
@yas
What do you think?
@nakamurarts
I posted some comments. Can you please check it again?
@nakamurarts
I posted some comments. Can you please check it?
@yas
Could you please review the patch?
sekinet → created an issue.
@nakamurarts
I have posted some comments. Can you please check them?
@yas
Could you please review the patch?
sekinet → created an issue. See original summary → .
@yas
Could you please review the patch?
@yas
Could you please review the patch?
sekinet → created an issue.
@yas
Could you please review the patch?
@yas
Sorry, I pushed again, could you please check?
@yas
I pushed the coding check fixes to the hotfix-3384733-fix-an-error-if-no-glyphicon-is-set-for-a-button
branch. Could you please check it?
@shubham_jain
The CSS file in Problem/Motivation was using an ID selector, which was causing an error in the Lint style check. This Issue is to remove that css file. The layout is broken as it is, so we are taking action to add CSS in the Rigel theme in Related issues.
@yas
Thank you for your information. I fixed it, could you please check again?
Thanks.
@yas
Could you please review the patch?
@yas
Could you please review the patch?
@yas
Thank you for your comment. I fixed, could you please check it?