- Issue created by @hosomitm
- Merge request !2120Issue #3405425: Remove unused JS (k8s_launch_template_vertical_tab.js) → (Merged) created by hosomitm
- last update
about 1 year ago Composer require failure - Status changed to Needs review
about 1 year ago 3:50pm 1 December 2023 - 🇺🇸United States yas California 🇺🇸
@sekinet
Can you please review the patch? What do you think? Thanks
- Status changed to RTBC
about 1 year ago 12:51am 4 December 2023 - 🇯🇵Japan sekinet
@yas @hosomitm
Thank you for providing the patch. It looks good to me. Because we don't need this JavaScript anymore.
Background.
Previously, source_type included yaml and added JavaScript to switch to the YAML tab when it was selected.
We have since refactored the source_type to remove the yaml from the source_type. However, I think we ware unable to remove this JavaScript file and the unnecessary file remained.Thanks.
- 🇺🇸United States yas California 🇺🇸
@sekinet
Thank you for reviewing the patch with your comment for the background. I'll merge the patch to
5.xand6.x, and close this issue as Fixed. - last update
about 1 year ago Composer require failure -
yas →
committed 6921482b on 6.x authored by
hosomitm →
Issue #3405425 by hosomitm, yas, sekinet: Remove unused JS (...
-
yas →
committed 6921482b on 6.x authored by
hosomitm →
- Status changed to Fixed
about 1 year ago 2:38am 4 December 2023 - Status changed to Needs work
about 1 year ago 2:39am 4 December 2023 - 🇺🇸United States yas California 🇺🇸
@hosomitm
Sorry, can you please create the patch for
5.xbranch? Thanks! - Merge request !2124Issue #3405425: Remove unused JS (k8s_launch_template_vertical_tab.js) → (Merged) created by hosomitm
- last update
about 1 year ago 367 pass - Status changed to Needs review
about 1 year ago 5:20am 4 December 2023 - 🇯🇵Japan hosomitm
@yas
I created a patch/merge request for 5.x.
Please review the code for 5.x. Thanks. - Status changed to RTBC
about 1 year ago 8:47am 4 December 2023 - 🇺🇸United States yas California 🇺🇸
@hosomitm
Thank you for the patch. I'll merge the patch to
5.x, and close this issue as Fixed. - last update
about 1 year ago 367 pass -
yas →
committed 4c145f1a on 5.x authored by
hosomitm →
Issue #3405425 by hosomitm, yas, sekinet: Remove unused JS (...
-
yas →
committed 4c145f1a on 5.x authored by
hosomitm →
- Status changed to Fixed
about 1 year ago 9:14am 4 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.