undefined - Contrib.social

🇯🇵Japan hosomitm

@yas

I have corrected the wording you pointed out.
Please review again.

🐛 | Cloud | Fix an issue where cloud service provider deletion fails in BDD test

🇯🇵Japan hosomitm

@yas

Please review this patch. Thanks.

🐛 | Cloud | Fix an issue where cloud service provider deletion fails in BDD test

📌 | Cloud | Add a BDD test step to take a screenshot to come up with the UI design document (openstack_flavor)

🇯🇵Japan hosomitm

hosomitm → created an issue.

📌 | Cloud | Add a BDD test step to take a screenshot to come up with the UI design document (cloud_config.delete)

🇯🇵Japan hosomitm

@yas

Please review this patch. Thanks.

📌 | Cloud | Add a BDD test step to take a screenshot to come up with the UI design document (cloud_config.delete)

🇯🇵Japan hosomitm

@yas

Please review this patch. Thanks.

📌 | Cloud | Add a BDD test step to take a screenshot to come up with the UI design document (openstack_flavor)

🇯🇵Japan hosomitm

hosomitm → created an issue.

📌 | OpenID Connect d ACCOUNT Client | Fix the dependent (parent) module version of drupal/openid_connect to use 3.x-dev

🇯🇵Japan hosomitm

hosomitm → created an issue.

📌 | OpenID Connect d ACCOUNT Client | Fix the dependent (parent) module version of drupal/openid_connect to use 3.x-dev

🇯🇵Japan hosomitm

@yas

Please review this patch. Thanks.

📌 | Cloud | Add a BDD test step to take a screenshot to come up with the UI design document (cloud_config)

🇯🇵Japan hosomitm

hosomitm → created an issue.

📌 | Cloud | Add a BDD test step to take a screenshot to come up with the UI design document (cloud_config)

🇯🇵Japan hosomitm

@yas

Please review this patch. Thanks.

📌 | Cloud | Add a BDD test step to take a screenshot to come up with the UI design document (cloud_config)

🇯🇵Japan hosomitm

There is still work to be done:
When I actually tried running Behat, the output was in HTML format instead of PNG format.
I need to modify it so that it is output in PNG format.

📌 | Cloud | Add a BDD test step to take a screenshot to come up with the UI design document (cloud_config)

🇯🇵Japan hosomitm

@yas

Please review this patch. Thanks.

📌 | Cloud | Add a BDD test step to take a screenshot to come up with the UI design document (openstack_network)

🇯🇵Japan hosomitm

📌 | Cloud | Add a BDD test step to take a screenshot to come up with the UI design document (openstack_network)

🇯🇵Japan hosomitm

@yas

I've rebased the source branch from the latest 6.x.
Please review again and merge.
Thanks.

📌 | Cloud | Add a BDD test step to take a screenshot to come up with the UI design document (openstack_network)

🇯🇵Japan hosomitm

@yas

Please review this patch. Thanks.

📌 | Cloud | Add a BDD test step to take a screenshot to come up with the UI design document (openstack_instance)

🇯🇵Japan hosomitm

📌 | Cloud | Add a BDD test step to take a screenshot to come up with the UI design document (openstack_instance)

🇯🇵Japan hosomitm

@yas

Please review this patch. Thanks.

📌 | Cloud | Add a BDD test step to take a screenshot to come up with the UI design document (OpenStack Launch template)

🇯🇵Japan hosomitm

📌 | Cloud | Add a BDD test step to take a screenshot to come up with the UI design document (cloud_config)

🇯🇵Japan hosomitm

@yas

Please review this patch. Thanks.

📌 | Cloud | Add a BDD test step to take a screenshot to come up with the UI design document (openstack_instance)

🇯🇵Japan hosomitm

There is still work to be done:

Change I take form screenshot to I take screenshot.

📌 | Cloud | Add a BDD test step to take a screenshot to come up with the UI design document (openstack_network)

🇯🇵Japan hosomitm

There is still work to be done:

Change I take from screenshot to I take screenshot.

🇯🇵Japan hosomitm

There is still work to be done:

Change I take from screenshot to I take screenshot.

📌 | Cloud | Take a screenshot to come up with the UI design document (openstack_router)

🇯🇵Japan hosomitm

@yas

Please review this patch. Thanks.

📌 | Cloud | Take a screenshot to come up with the UI design document (openstack_router)

📌 | Cloud | Add a BDD test step to take a screenshot to come up with the UI design document (openstack_role)

🇯🇵Japan hosomitm

hosomitm → created an issue.

📌 | Cloud | Add a BDD test step to take a screenshot to come up with the UI design document (openstack_role)

🇯🇵Japan hosomitm

📌 | Cloud | Add a BDD test step to take a screenshot to come up with the UI design document (openstack_role)

🇯🇵Japan hosomitm

@yas

Please review this patch. Thanks.

📌 | Cloud | Add a BDD test step to take a screenshot to come up with the UI design document (OpenStack Launch template)

🇯🇵Japan hosomitm

hosomitm → created an issue.

📌 | Cloud | Add a BDD test step to take a screenshot to come up with the UI design document (OpenStack Launch template)

🇯🇵Japan hosomitm

🇯🇵Japan hosomitm

hosomitm → created an issue.

📌 | Cloud | Fix the display of "Allocated Resources" to be centered

🇯🇵Japan hosomitm

@yas

Please review the code. Thanks.

📌 | Cloud | Fix the display of "Allocated Resources" to be centered

🇯🇵Japan hosomitm

hosomitm → created an issue.

📌 | Cloud | Refactor to native JavaScript from jQuery (k8s_refresh_resource_trigger.js)

🇯🇵Japan hosomitm

@yas

I have corrected the indicated source code.
Please review again.

📌 | Cloud | Refactor to native JavaScript from jQuery (k8s_refresh_resource_trigger.js)

🇯🇵Japan hosomitm

@yas

Please review the code. Thanks.

Note:
If you merge this Merge request, the argument will not be passed correctly to "updatedNodes" of k8s_node_heatmap.js. When refactoring k8s_node_heatmap.js, keep in mind that you need to make sure that the arguments are passed correctly from k8s_refresh_resource_trigger.js to updatedNodes in k8s_node_heatmap.js.

📌 | Cloud | Refactor to native JavaScript from jQuery (k8s_refresh_resource_trigger.js)

🇯🇵Japan hosomitm

hosomitm → created an issue.

📌 | Cloud | Remove unused JS (k8s_launch_template_vertical_tab.js)

🇯🇵Japan hosomitm

@yas

I created a patch/merge request for 5.x.
Please review the code for 5.x. Thanks.

📌 | Cloud | Remove unused JS (k8s_launch_template_vertical_tab.js)

🇯🇵Japan hosomitm

@yas

Please review the code. Thanks.

📌 | Cloud | Remove unused JS (k8s_launch_template_vertical_tab.js)

🇯🇵Japan hosomitm

hosomitm → created an issue.

📌 | Cloud | Refactor to native JavaScript from jQuery (openstack_form.js)

🇯🇵Japan hosomitm

@yas

I created a patch/merge request for 5.x.
Please review the code for 5.x. Thanks.

📌 | Rigel | Remove unused CSS for Choices.js

🇯🇵Japan hosomitm

@yas

Please review the code. Thanks.

📌 | Rigel | Remove unused CSS for Choices.js

🇯🇵Japan hosomitm

hosomitm → created an issue.

📌 | Rigel | Add CSS to improve the appearance of the dropdown list generated by tom-select.js

🇯🇵Japan hosomitm

@yas

Please review the code. Thanks.

📌 | Rigel | Add CSS to improve the appearance of the dropdown list generated by tom-select.js

🇯🇵Japan hosomitm

hosomitm → created an issue.

📌 | Cloud | Refactor to native JavaScript from jQuery (openstack_form.js)

🇯🇵Japan hosomitm

@yas

Please review the code. Thanks.

📌 | Cloud | Refactor to native JavaScript from jQuery (k8s_entity_metrics.js)

🇯🇵Japan hosomitm

@yas

Please review the code. Thanks.

📌 | Cloud | Refactor to native JavaScript from jQuery (k8s_entity_metrics.js)

🇯🇵Japan hosomitm

hosomitm → created an issue.

📌 | Cloud | Refactor to native JavaScript from jQuery (openstack_form.js)

🇯🇵Japan hosomitm

@yas

I'm sorry. I overlooked a violation of coding standards.

I have fixed it, so please check it.

Thank you.

📌 | Cloud | Refactor to native JavaScript from jQuery (openstack_form.js)

🇯🇵Japan hosomitm

@yas

Please review the code.

I used the tom-select library to customize the Flavor drop-down list in the Create and Edit forms of Launch Template, but as a result, tom-select automatically rewrote the for attribute in the <label> tag. , and the Behat scenario can no longer find the <select> for Flavor.
As a workaround, Behat is trying to avoid this problem by directly specifying the id attribute of the
tag instead of the Label value.
The way the scenario is written is different from other form elements, but is this acceptable?

Thanks.

📌 | Cloud | Refactor to native JavaScript from jQuery (openstack_form.js)

🇯🇵Japan hosomitm

The following BDD test scenario fails to select Flavor. I think the problem is due to the modification of this issue.

BDD file: OpenStack-ATDD-03-05-OperateInstances.feature
Scenario: Create a launch template by a user and a cloud admin

I will make additional modifications so that the BDD scenario can pass.

📌 | Rigel | Add CSS to improve the appearance of the dropdown list generated by choices.js

🇯🇵Japan hosomitm

@yas

Please review the code. Thanks.

📌 | Rigel | Add CSS to improve the appearance of the dropdown list generated by choices.js

🇯🇵Japan hosomitm

hosomitm → created an issue.

📌 | Cloud | Refactor to native JavaScript from jQuery (openstack_form.js)

🇯🇵Japan hosomitm

@yas

Please review the code. Thanks.

📌 | Cloud | Refactor to native JavaScript from jQuery (openstack_form.js)

🇯🇵Japan hosomitm

hosomitm → created an issue.

🐛 | Cloud | Fix an issue where OpenStack Instance does not stop in BDD test for SPA

🐛 | Cloud | Fix to set a user in the 'Authored by' field in OpenStack launching template in SPA (drupal/cloud_dashboard)

🇯🇵Japan hosomitm

@yas

Please review the code. Thanks.

🐛 | Cloud | Fix to set a user in the 'Authored by' field in OpenStack launching template in SPA (drupal/cloud_dashboard)

🇯🇵Japan hosomitm

@yas

Please review the code. Thanks.

🇯🇵Japan hosomitm

hosomitm → created an issue.

🐛 | Cloud | Fix an issue where OpenStack Instance does not stop in BDD test for SPA

🐛 | Cloud | Fix an issue where the OpenStack launch Template is not displayed on the list screen after creating it in the BDD test for SPA

🇯🇵Japan hosomitm

hosomitm → created an issue.

🐛 | Cloud | Fix an issue where the OpenStack launch Template is not displayed on the list screen after creating it in the BDD test for SPA

🇯🇵Japan hosomitm

@yas

Please review the patch. Thanks.

🇯🇵Japan hosomitm

hosomitm → created an issue.

📌 | OpenID Connect d ACCOUNT Client | Comply with Drupal coding standards (1) (ESLint)

🇯🇵Japan hosomitm

@yas

Please review the code. Thanks.

📌 | OpenID Connect d ACCOUNT Client | Comply with Drupal coding standards (1) (ESLint)

🇯🇵Japan hosomitm

📌 | OpenID Connect d ACCOUNT Client | Comply with Drupal coding standards (1) (ESLint)

🇯🇵Japan hosomitm

hosomitm → made their first commit to this issue’s fork.

📌 | Cloud | Refactor SPA well-Known protocol retrieval to use API instead of hardcoding

🇯🇵Japan hosomitm

@yas @ryo-yamashita

Please review the code. Thank you.

📌 | Cloud | Refactor SPA well-Known protocol retrieval to use API instead of hardcoding

📌 | Cloud | Add well-known port protocol name items to the IP protocol dropdown list in OpenStack security group form (SPA)

🇯🇵Japan hosomitm

hosomitm → created an issue.

📌 | Cloud | Add well-known port protocol name items to the IP protocol dropdown list in OpenStack security group form (SPA)

🇯🇵Japan hosomitm

@yas @ryo-yamashita

Please review the code.

As a known remaining issue, the Well-known protocols list is hard-coded, so it is necessary to make the list added in #3374538 available as a JSON API.

Thank you.

🇯🇵Japan hosomitm

hosomitm → created an issue.

📌 | Cloud Orchestrator | Add drupal/openid_connect_daccount module

🇯🇵Japan hosomitm

@yas

I sorted the modules to install in ascending alphabetical order.
For some reason there were two node modules, so I deleted one.

Please review again. Thank you.

📌 | Cloud Orchestrator | Add drupal/openid_connect_daccount module

🇯🇵Japan hosomitm

@yas

I had a feeling that they were probably trying to sort alphabetically by Core modules, then by contributed modules, and then by Cloud Orchestrator instead of a simple alphabetical order.
However, that rule seems to be breaking down a bit.

I'm going to follow your advice and sort by simple alphabetical order.

📌 | Cloud Orchestrator | Add drupal/openid_connect_daccount module

🇯🇵Japan hosomitm

@yas

Please review the patch. Thank you.

📌 | Cloud Orchestrator | Add drupal/openid_connect_daccount module

🐛 | Cloud | Fix all ICMP interpreted as 1-65535 when receiving security group rules from the OpenStack server

🇯🇵Japan hosomitm

hosomitm → created an issue.

🐛 | Cloud | Fix all ICMP interpreted as 1-65535 when receiving security group rules from the OpenStack server

🇯🇵Japan hosomitm

@yas

Please review the code. Thank you.

📌 | Cloud | Add well-known port protocol name items to the IP protocol dropdown list in OpenStack security group form

🇯🇵Japan hosomitm

hosomitm → created an issue.

📌 | Cloud | Add well-known port protocol name items to the IP protocol dropdown list in OpenStack security group form

🇯🇵Japan hosomitm

@yas

I have fixed the issues pointed out in the review.
Please review again. Thanks you.

📌 | Cloud | Add well-known port protocol name items to the IP protocol dropdown list in OpenStack security group form

🇯🇵Japan hosomitm

@yas

Please review the code. Thank you.

🇯🇵Japan hosomitm

hosomitm → created an issue.

📌 | Rigel | Expand the tabs for resources at startup

🇯🇵Japan hosomitm

@yas

Please review the patch. Thank you.

📌 | Rigel | Expand the tabs for resources at startup

🇯🇵Japan hosomitm

hosomitm → created an issue.

✨ | Cloud | Add a menu link to display the module permission list in the SPA

🇯🇵Japan hosomitm

@yas

Please review the code. Thank you.

✨ | Cloud | Add a menu link to display the module permission list in the SPA

🇯🇵Japan hosomitm

hosomitm → created an issue.

🐛 | Cloud | Fix errors of undefined key in the OpenStack network provider

🇯🇵Japan hosomitm

@yas

Thank you for your comment.
I have refactored it.
Please review it again. Thank you.

🐛 | Cloud | Fix errors of undefined key in the OpenStack network provider

🇯🇵Japan hosomitm

@yas

Please review the code. Thank you.

🐛 | Cloud | Fix errors of undefined key in the OpenStack network provider

✨ | Cloud | Add a link to display the user management on the Cloud dashboard in SPA if user have a permission

🇯🇵Japan hosomitm

hosomitm → created an issue.

✨ | Cloud | Add a link to display the user management on the Cloud dashboard in SPA if user have a permission

🇯🇵Japan hosomitm

@yas @ryo-yamashita

Please review the code.

The "Administration" link is displayed when logged in as a user with the View cloud service provider administration list permission.
The "Users" link is displayed when logged in as a user with the Administer users permission and the RoleAssign → module is installed.

I have added an API to the cloud module's ApiController for determining whether each menu should be displayed. Is there any issue with adding it in that location?

Thank you.

🐛 | Rigel | Fix the style of the 2nd level element when there is no 3rd level element in the main menu

🇯🇵Japan hosomitm

hosomitm → created an issue.

🐛 | Rigel | Fix the style of the 2nd level element when there is no 3rd level element in the main menu

🇯🇵Japan hosomitm

@yas @baldwinlouie

I fixed bug with links not working.
Please review the patch. Thank you.

🐛 | Rigel | Fix the style of the 2nd level element when there is no 3rd level element in the main menu

🇯🇵Japan hosomitm

@yas @baldwinlouie

I'm sorry.
There was a problem that clicking the link did not transition to the link destination.
I will fix it.

📌 | Cloud Orchestrator | Add permission to assign cloud_operator role for other users to cloud_admin

🇯🇵Japan hosomitm

@yas @baldwinlouie

Please review the patch. Thank you.

🐛 | Rigel | Fix the style of the 2nd level element when there is no 3rd level element in the main menu

🇯🇵Japan hosomitm

@yas @baldwinlouie

Please review the patch. Thank you.

📌 | Cloud Orchestrator | Add permission to assign cloud_operator role for other users to cloud_admin

🇯🇵Japan hosomitm

hosomitm → created an issue.