- Issue created by @hosomitm
- last update
over 1 year ago 366 pass - @hosomitm opened merge request.
- last update
over 1 year ago 366 pass - Status changed to Needs review
over 1 year ago 7:52am 14 July 2023 - Status changed to Needs work
over 1 year ago 9:20am 14 July 2023 - 🇺🇸United States yas California 🇺🇸
@hosomitm
Thank you for the patch. I posted my comments. Thanks!
- last update
over 1 year ago 366 pass - 🇺🇸United States yas California 🇺🇸
@hostomitm
Thank you for the update. The
foreach ($items as $item)
loop should beforeach ($items ?: [] as $item)
style. Thanks - last update
over 1 year ago 366 pass - Status changed to Needs review
over 1 year ago 9:47am 17 July 2023 - 🇯🇵Japan hosomitm
@yas
I have fixed the issues pointed out in the review.
Please review again. Thanks you. - Status changed to RTBC
over 1 year ago 10:24pm 17 July 2023 - 🇺🇸United States yas California 🇺🇸
@hostomitm
Thank you for the update. I ran the BDD tests and it worked successfully. I'll merge the patch to
5.x
and6.x
, and close this issue as Fixed. - last update
over 1 year ago 366 pass -
yas →
committed d75e34bb on 6.x authored by
hosomitm →
Issue #3374538 by hosomitm, yas: Add well-known port protocol name items...
-
yas →
committed d75e34bb on 6.x authored by
hosomitm →
-
yas →
committed 5c27bdf0 on 5.x authored by
hosomitm →
Issue #3374538 by hosomitm, yas: Add well-known port protocol name items...
-
yas →
committed 5c27bdf0 on 5.x authored by
hosomitm →
- Status changed to Fixed
over 1 year ago 10:26pm 17 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.