- Issue created by @hosomitm
- @hosomitm opened merge request.
- Status changed to Needs review
over 1 year ago 6:00am 26 July 2023 - Status changed to Needs work
over 1 year ago 6:10am 26 July 2023 - πΊπΈUnited States yas California πΊπΈ
@hostomitm
Thank you for the patch. I posted my comment to ask you to do the refactoring. Thanks!
- π―π΅Japan hosomitm
@yas
I had a feeling that they were probably trying to sort alphabetically by Core modules, then by contributed modules, and then by Cloud Orchestrator instead of a simple alphabetical order.
However, that rule seems to be breaking down a bit.I'm going to follow your advice and sort by simple alphabetical order.
- πΊπΈUnited States yas California πΊπΈ
@hosomitm
I had a feeling that they were probably trying to sort alphabetically by Core modules, then by contributed modules, and then by Cloud Orchestrator instead of a simple alphabetical order.
Yes, I agreed.
- Status changed to Needs review
over 1 year ago 8:25am 26 July 2023 - π―π΅Japan hosomitm
@yas
I sorted the modules to install in ascending alphabetical order.
For some reason there were two node modules, so I deleted one.Please review again. Thank you.
- Status changed to RTBC
over 1 year ago 8:32am 26 July 2023 - πΊπΈUnited States yas California πΊπΈ
@hosomitm
Thank you for the update. It looks good to me. I'll merge the patch to
5.x
and6.x
, and close this issue as Fixed. -
yas β
committed 34628561 on 6.x authored by
hosomitm β
Issue #3376991 by hosomitm, yas: Add drupal/openid_connect_daccount...
-
yas β
committed 34628561 on 6.x authored by
hosomitm β
- Status changed to Fixed
over 1 year ago 8:34am 26 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.