- Issue created by @hosomitm
- Merge request !2104Issue #3401473: Refactor to native JavaScript from jQuery (openstack_form.js) β (Merged) created by hosomitm
- last update
about 1 year ago Composer require failure - First commit to issue fork.
- last update
about 1 year ago Composer require failure - Status changed to Needs review
about 1 year ago 1:50pm 14 November 2023 - Status changed to Needs work
about 1 year ago 2:03am 15 November 2023 - π―π΅Japan hosomitm
The following BDD test scenario fails to select Flavor. I think the problem is due to the modification of this issue.
BDD file: OpenStack-ATDD-03-05-OperateInstances.feature
Scenario: Create a launch template by a user and a cloud adminI will make additional modifications so that the BDD scenario can pass.
- last update
about 1 year ago Composer require failure - last update
about 1 year ago Composer require failure - last update
about 1 year ago Composer require failure - Status changed to Needs review
about 1 year ago 11:12am 23 November 2023 - π―π΅Japan hosomitm
@yas
Please review the code.
I used the tom-select library to customize the Flavor drop-down list in the Create and Edit forms of Launch Template, but as a result, tom-select automatically rewrote the for attribute in the
<label>
tag. , and the Behat scenario can no longer find the<select>
for Flavor.
As a workaround, Behat is trying to avoid this problem by directly specifying the id attribute of the
tag instead of the Label value.
The way the scenario is written is different from other form elements, but is this acceptable?Thanks.
- last update
about 1 year ago Composer require failure - last update
about 1 year ago Composer require failure - last update
about 1 year ago Composer require failure - Status changed to Needs work
about 1 year ago 6:22am 24 November 2023 - πΊπΈUnited States yas California πΊπΈ
@hosomitm
Thank you for the patch. It should be fine as long as BDD tests have been passed successfully in both between the normal Drupal and SPA version. Please fix the
stylelint
error at first.Thanks
- last update
about 1 year ago Composer require failure - Status changed to Needs review
about 1 year ago 7:37am 24 November 2023 - π―π΅Japan hosomitm
@yas
I'm sorry. I overlooked a violation of coding standards.
I have fixed it, so please check it.
Thank you.
- Status changed to Needs work
about 1 year ago 7:50am 24 November 2023 - πΊπΈUnited States yas California πΊπΈ
@hostomitm
Thank you for the update. It still needs to work: https://git.drupalcode.org/issue/cloud-3401473/-/jobs/388242
../modules/custom/cloud-3401473/modules/cloud_service_providers/openstack/css/openstack_form.css 4:10 β Unexpected unit length-zero-no-unit
Thanks
- last update
about 1 year ago Composer require failure - last update
about 1 year ago Composer require failure - Status changed to Needs review
about 1 year ago 6:56am 28 November 2023 - last update
about 1 year ago Composer require failure - Status changed to RTBC
about 1 year ago 11:14pm 29 November 2023 - πΊπΈUnited States yas California πΊπΈ
@hosomitm
Thank you for the refactoring. I'll merge the patch to
5.x
and6.x
, and close this issue as Fixed. - last update
about 1 year ago Composer require failure -
yas β
committed 45651879 on 6.x authored by
hosomitm β
Issue #3401473 by hosomitm, yas: Refactor to native JavaScript from...
-
yas β
committed 45651879 on 6.x authored by
hosomitm β
- Status changed to Needs work
about 1 year ago 11:18pm 29 November 2023 - πΊπΈUnited States yas California πΊπΈ
@hosomitm
Can you provide the patch / merge request for
5.x
? Thanks! - Merge request !2117Issue #3401473: Refactor to native JavaScript from jQuery (openstack_form.js) β (Merged) created by hosomitm
- last update
about 1 year ago 367 pass - Status changed to Needs review
about 1 year ago 12:48am 1 December 2023 - π―π΅Japan hosomitm
@yas
I created a patch/merge request for 5.x.
Please review the code for 5.x. Thanks. - last update
about 1 year ago 367 pass - Status changed to RTBC
about 1 year ago 9:36am 3 December 2023 - πΊπΈUnited States yas California πΊπΈ
@hostomitm
Thank you for supplying the patch for
5.x
. I tested it and it looks good. I'll merge the patch to6.x
, and close this issue as Fixed. - last update
about 1 year ago 367 pass -
yas β
committed 769469e5 on 5.x authored by
hosomitm β
Issue #3401473 by hosomitm, yas: Refactor to native JavaScript from...
-
yas β
committed 769469e5 on 5.x authored by
hosomitm β
- Status changed to Fixed
about 1 year ago 9:36am 3 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.