- Issue created by @hosomitm
- Merge request !2128Issue #3406159: Refactor to native JavaScript from jQuery (k8s_refresh_resource_trigger.js) → (Merged) created by hosomitm
- last update
7 months ago Composer require failure - First commit to issue fork.
- last update
7 months ago Composer require failure - Status changed to Needs review
7 months ago 9:46am 5 December 2023 - 🇯🇵Japan hosomitm
@yas
Please review the code. Thanks.
Note:
If you merge this Merge request, the argument will not be passed correctly to "updatedNodes" of k8s_node_heatmap.js. When refactoring k8s_node_heatmap.js, keep in mind that you need to make sure that the arguments are passed correctly from k8s_refresh_resource_trigger.js to updatedNodes in k8s_node_heatmap.js. - Status changed to Needs work
7 months ago 9:48am 5 December 2023 - 🇺🇸United States yas California 🇺🇸
@hosomitm
Thank you for the refactoring. I posted my comment. Thanks!
- last update
7 months ago Composer require failure - Status changed to Needs review
7 months ago 2:01pm 5 December 2023 - 🇯🇵Japan hosomitm
@yas
I have corrected the indicated source code.
Please review again. - Status changed to RTBC
7 months ago 10:09pm 5 December 2023 - 🇺🇸United States yas California 🇺🇸
@hosomitm
Thank you for the update. It looks good to me. I'll merge the patch to
5.xand6.x, and close this issue as Fixed. - last update
7 months ago Composer require failure -
yas →
committed 3c44c9f7 on 6.x authored by
hosomitm →
Issue #3406159 by hosomitm, yas: Refactor to native JavaScript from...
-
yas →
committed 3c44c9f7 on 6.x authored by
hosomitm →
-
yas →
committed dfc9b8bb on 5.x authored by
hosomitm →
Issue #3406159 by hosomitm, yas: Refactor to native JavaScript from...
-
yas →
committed dfc9b8bb on 5.x authored by
hosomitm →
- Status changed to Fixed
7 months ago 10:27pm 5 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.