- Issue created by @sekinet
- Merge request !2121Issue #3405430 by sekinet: Refactor to native JavaScript from jQuery... → (Merged) created by sekinet
- last update
7 months ago Composer require failure - Status changed to Needs review
7 months ago 9:39am 1 December 2023 - Status changed to RTBC
7 months ago 12:45am 4 December 2023 - 🇯🇵Japan sekinet
@yas @hosomitm
Thank you for providing the patch. It looks good to me. Because we don't need this JavaScript anymore.
Background.
Previously, source_type included yaml and added JavaScript to switch to the YAML tab when it was selected.
We have since refactored thesource_typeto remove theyamlfrom thesource_type. However, I think we ware unable to remove this JavaScript file and the unnecessary file remained.Thanks.
- Status changed to Needs review
7 months ago 12:56am 4 December 2023 - 🇯🇵Japan sekinet
Sorry, the above comment was an error in commenting on another Issue. Please review the patch. Thanks.
- First commit to issue fork.
- last update
7 months ago Composer require failure - Status changed to Needs work
7 months ago 2:41am 4 December 2023 - 🇺🇸United States yas California 🇺🇸
@sekinet
Thank you for the refactoring. Can you please create the patch for
5.xbranch, too?After that, I'll merge the patch to
5.xand6.x, and close this issue as Fixed - Merge request !2123Issue #3386224 by asai.noriaki, yas: Fix an issue where clicking an OpenStack... → (Open) created by sekinet
- Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8last update
7 months ago Not currently mergeable. - Merge request !2125Resolve #3405430 "Refactor to native javascript from jquery k8s launch template source type 5x" → (Merged) created by sekinet
- last update
7 months ago 367 pass - Status changed to Needs review
7 months ago 5:16am 4 December 2023 - 🇯🇵Japan sekinet
@yas
I have also created a patch for the 5.x branch. Could you please check it?
- last update
7 months ago 367 pass - 🇺🇸United States yas California 🇺🇸
@sekinet
Thank you for supplying the patch for
5.x. I'll merge the patch to5.x, and close this issue as Fixed. - Status changed to RTBC
7 months ago 9:24am 4 December 2023 - last update
7 months ago 367 pass - last update
7 months ago Composer require failure - Status changed to Fixed
7 months ago 9:25am 4 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.