- Issue created by @phyllanthus
- last update
over 1 year ago 367 pass - @nakamurarts opened merge request.
- last update
over 1 year ago 367 pass - last update
over 1 year ago 367 pass - last update
over 1 year ago 367 pass - Status changed to Needs review
over 1 year ago 7:38am 12 September 2023 - First commit to issue fork.
- last update
over 1 year ago 367 pass - Status changed to Needs work
over 1 year ago 9:37am 12 September 2023 - πΊπΈUnited States yas California πΊπΈ
@nakamurarts
Thank you for the patch. I posted my comment. According to the following modification, I think the patch is removing the existing testing for
"No items." in the table
. So please keep the existing test for"No items." in the table
. In that sense,
you may want t addNo items.
andAccess denied.
into the new column such as amessage
inExamples:
table of scenario.- And I should "No items." in the table
+ And I should "Access denied." in the tableBecause I see the following code in your patch:
$message = $has_view_cloud_service_provider_permission ? t('No items.') : t('Access denied.');
Thanks
- last update
over 1 year ago 367 pass - Open on Drupal.org βCore: 10.0.7 + Environment: PHP 8.2 & MySQL 8last update
over 1 year ago Waiting for branch to pass - last update
over 1 year ago 367 pass - last update
over 1 year ago 367 pass - last update
over 1 year ago 367 pass - last update
over 1 year ago 367 pass - last update
over 1 year ago 367 pass - last update
over 1 year ago 367 pass - last update
over 1 year ago 367 pass - last update
about 1 year ago 367 pass - Status changed to Needs review
about 1 year ago 9:57am 26 September 2023 @yas
Thank you for review.Following a suggestion from a previous meeting, I have added a test case to `K8s-ATDD-01-01-ReadNoUserResources.feature` that checks for message changes due to user roles.
- Status changed to Needs work
about 1 year ago 7:04am 27 September 2023 - π―π΅Japan sekinet
@nakamurarts
I have posted some comments. Can you please check them?
- last update
about 1 year ago 367 pass - last update
about 1 year ago 367 pass - last update
about 1 year ago 367 pass - last update
about 1 year ago Composer require failure - last update
about 1 year ago Composer require failure - last update
about 1 year ago Composer require failure - last update
about 1 year ago Composer require failure - last update
about 1 year ago Composer require failure - last update
about 1 year ago Composer require failure - last update
about 1 year ago Composer require failure - last update
about 1 year ago Composer require failure - last update
about 1 year ago Composer require failure - last update
about 1 year ago Composer require failure - last update
about 1 year ago Composer require failure - last update
about 1 year ago Composer require failure - last update
about 1 year ago Composer require failure - last update
about 1 year ago Composer require failure - Status changed to Needs review
about 1 year ago 5:41am 16 November 2023 Only the addition of BDD test cases was performed, as the appropriate messages are already displayed now.
Also, fixed the permission name ('view own openstack flavor')
- Status changed to RTBC
about 1 year ago 1:35am 17 November 2023 - π―π΅Japan sekinet
@nakamiurarts @yas
The patch looks good to me. Thanks.
- πΊπΈUnited States yas California πΊπΈ
@sekinet
Thank you for your review.
@nakamurarts
Thank you for the update. I'll merge the patch to
5.x
and6.x
, and close this issue as Fixed. - last update
about 1 year ago Composer require failure -
yas β
committed 9b02215d on 6.x authored by
nakamurarts β
Issue #3386610 by yas, nakamurarts, sekinet: Add a BDD test suite when a...
-
yas β
committed 9b02215d on 6.x authored by
nakamurarts β
-
yas β
committed a30fb0ff on 5.x authored by
nakamurarts β
Issue #3386610 by yas, nakamurarts, sekinet: Add a BDD test suite when a...
-
yas β
committed a30fb0ff on 5.x authored by
nakamurarts β
- Status changed to Fixed
about 1 year ago 3:03am 17 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.