- Issue created by @sekinet
- Merge request !2110Resolve #3403261 "Add a bdd test suite for openstack image share to projects" β (Merged) created by sekinet
- last update
over 1 year ago Composer require failure - Status changed to Needs review
over 1 year ago 3:59am 22 November 2023 - Status changed to Needs work
over 1 year ago 4:53am 22 November 2023 - πΊπΈUnited States yas California πΊπΈ
@sekinet
Thank you for the patch. I posted my minor comments. Thanks!
- πΊπΈUnited States yas California πΊπΈ
@sekinet
Also, please fix the following git error:
2110.diff:54: trailing whitespace. (function(){const t=document.createElement("link").relList;if(t&&t.supports&&t.supports("modulepreload"))return;for(const i of document.querySelectorAll('link[rel="modulepreload"]'))a(i);new MutationObserver(i=>{for(const o of i)if(o.type==="childList")for(const s of o.addedNodes)s.tagName==="LINK"&&s.rel==="modulepreload"&&a(s)}).observe(document,{childList:!0,subtree:!0});function n(i){const o={};return i.integrity&&(o.integrity=i.integrity),i.referrerpolicy&&(o.referrerPolicy=i.referrerpolicy),i.crossorigin==="use-credentials"?o.credentials="include":i.crossorigin==="anonymous"?o.credentials="omit":o.credentials="same-origin",o}function a(i){if(i.ep)return;i.ep=!0;const o=n(i);fetch(i.href,o)}})();Drupal.t("$");Drupal.t("%");Drupal.t("%action was applied to @count item.");Drupal.t("%action was applied to @count items.");Drupal.t(", ");Drupal.t("- All -");Drupal.t("- Any -");Drupal.t("- None -");Drupal.t("1 Day");Drupal.t("1 Hour");Drupal.t("1 Minute");Drupal.t("1 Week");Drupal.t("1 Year");Drupal.t("1 day");Drupal.t("1 item");Drupal.t("1 week");Drupal.t("1");Drupal.t(`16-32 Characters, e.g. 12ABCDEFGHIJKVWXYZ89 . If <em>Assume Role</em> warning: 1 line adds whitespace errors.
- last update
over 1 year ago Composer require failure - last update
over 1 year ago Composer require failure - Status changed to Needs review
over 1 year ago 7:06am 22 November 2023 - π―π΅Japan sekinet
@yas
Thank you for your comments. I have fixed them, so could you please check them?
- Status changed to RTBC
over 1 year ago 1:18am 23 November 2023 - πΊπΈUnited States yas California πΊπΈ
@sekinet
Thank you for the update. I ran the BDD tests for the Drupal normal version and SPA; and they have been passed successfully. I'll merge the patch to
5.x
and6.x
, and close this issue as Fixed. - last update
over 1 year ago Composer require failure -
yas β
committed c73443d4 on 6.x authored by
sekinet β
Issue #3403261 by sekinet, yas: Add a BDD test suite for OpenStack Image...
-
yas β
committed c73443d4 on 6.x authored by
sekinet β
-
yas β
committed 0d82b16f on 5.x authored by
sekinet β
Issue #3403261 by sekinet, yas: Add a BDD test suite for OpenStack Image...
-
yas β
committed 0d82b16f on 5.x authored by
sekinet β
- Status changed to Fixed
over 1 year ago 1:21am 23 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.