- Issue created by @sekinet
- @sekinet opened merge request.
- Status changed to Needs review
over 1 year ago 2:59am 1 September 2023 - Status changed to Needs work
over 1 year ago 3:39am 1 September 2023 - πΊπΈUnited States yas California πΊπΈ
@sekinet
Thank you for the fix. I posted my comment. Thanks
- Status changed to Needs review
over 1 year ago 4:31am 1 September 2023 - π―π΅Japan sekinet
@yas
Thank you for your comment. I fixed, could you please check it?
- Status changed to RTBC
over 1 year ago 4:50am 1 September 2023 - πΊπΈUnited States yas California πΊπΈ
@sekinet
Thank you for the update. It looks more cleaner. I'll merge the patch to
6.x
, and close this issue as Fixed. -
yas β
committed c544570e on 6.x authored by
sekinet β
Issue #3384733 by sekinet, yas: Fix an error if no glyphicon is set for...
-
yas β
committed c544570e on 6.x authored by
sekinet β
-
yas β
committed 574e4708 on 5.x authored by
sekinet β
Issue #3384733 by sekinet, yas: Fix an error if no glyphicon is set for...
-
yas β
committed 574e4708 on 5.x authored by
sekinet β
- Status changed to Fixed
over 1 year ago 4:55am 1 September 2023 - @sekinet opened merge request.
- @sekinet opened merge request.
- Status changed to Needs review
over 1 year ago 1:52am 6 September 2023 - π―π΅Japan sekinet
@yas
I pushed the coding check fixes to the
hotfix-3384733-fix-an-error-if-no-glyphicon-is-set-for-a-button
branch. Could you please check it? - πΊπΈUnited States yas California πΊπΈ
@sekinet
I didn't see any patch at the branch "hotfix-3384733-fix-an-error-if-no-glyphicon-is-set-for-a-button". Can you please double-check it?
Thanks
- π―π΅Japan sekinet
@yas
Sorry, I pushed again, could you please check?
- Status changed to RTBC
over 1 year ago 3:41am 6 September 2023 - πΊπΈUnited States yas California πΊπΈ
@sekinet
Thank you for the update. I'll merge the patch to
5.x
and6.x
, and close this issue as Fixed. -
yas β
committed 092f7081 on 6.x authored by
sekinet β
Issue #3384733 by sekinet, yas: Hotfix - Fix an error if no glyphicon is...
-
yas β
committed 092f7081 on 6.x authored by
sekinet β
-
yas β
committed b0ff6b22 on 5.x authored by
sekinet β
Issue #3384733 by sekinet, yas: Hotfix - Fix an error if no glyphicon is...
-
yas β
committed b0ff6b22 on 5.x authored by
sekinet β
- Status changed to Fixed
over 1 year ago 3:55am 6 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.