Add a function to FeatureContext to take a screenshot of a Form

Issue created by @sekinet
Merge request !2130Issue #3406395 by sekinet: Add a function to FeatureContext to take a screenshot of a Form → (Merged) created by sekinet
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update 7 months ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update 7 months ago
Composer require failure
Status changed to Needs review 7 months ago5:56am 6 December 2023
Comment 7 months ago →
🇯🇵Japan sekinet
@yas

Could you please review the patch?
Comment 7 months ago →
🇯🇵Japan sekinet
Status changed to Needs work 7 months ago8:07am 6 December 2023
Comment 7 months ago →
🇺🇸United States yas California 🇺🇸
@sekinet

I posted my comment, however I think we should refactor the existing code base at https://github.com/docomoinnovations/drupalextension/blob/6.x/src/Drupal...

Thanks!
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update 7 months ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update 7 months ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update 7 months ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update 7 months ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update 7 months ago
Composer require failure
Status changed to Needs review 7 months ago3:20am 11 December 2023
Comment 7 months ago →
🇯🇵Japan sekinet
@yas

Thank you for your comment. I have fixed it as you suggested. There is an error in phpstan, but it should go away once the PR#24 is merged. Could you please check?
Status changed to Needs work 7 months ago1:59am 12 December 2023
Comment 7 months ago →
🇯🇵Japan sekinet
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update 7 months ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update 7 months ago
Composer require failure
Status changed to Needs review 7 months ago4:40am 12 December 2023
Comment 7 months ago →
🇯🇵Japan sekinet
@yas

Fixed to output with I take screenshot. Refactoring has been done accordingly. Could you please check it?
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update 7 months ago
Composer require failure
Comment 7 months ago →
🇺🇸United States baldwinlouie
@sekinet This is a great patch. It looks good to me.
Comment 7 months ago →
🇺🇸United States yas California 🇺🇸
@baldwinlouie

Thank you for your review.

@sekinet

Thank you for the patch. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.
Status changed to RTBC 7 months ago6:46am 13 December 2023
Comment 7 months ago →
System Message

yas → committed 8fe2f723 on 6.x authored by sekinet →
Issue #3406395 by sekinet, yas, baldwinlouie: Add a function to...
Comment 7 months ago →
System Message

yas → committed fff2f699 on 5.x authored by sekinet →
Issue #3406395 by sekinet, yas, baldwinlouie: Add a function to...
Status changed to Fixed 7 months ago7:38am 13 December 2023
Comment 7 months ago →
🇺🇸United States yas California 🇺🇸
Comment 6 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Add a function to FeatureContext to take a screenshot of a Form

Problem/Motivation

Merge Requests

!2130Add a function to FeatureContext to take a screenshot of a Form
Merged

Comments & Activities

Add a function to FeatureContext to take a screenshot of a Form

Problem/Motivation

Merge Requests

!2130Add a function to FeatureContext to take a screenshot of a FormMerged

Comments & Activities

!2130Add a function to FeatureContext to take a screenshot of a Form
Merged