Fix the access control on the cloud launch template before approval

@nakamurarts

Thank you for the fix.

@sekinet

What do you think?

@nakamurarts

The PhpUnit test failed at https://www.drupal.org/pift-ci-job/2705840 → . Can you please fix it? Thanks

@nakamurarts @yas

Thank you for the patch.

We may want to confirm this fix with a BDD test. How about adding the following scenario for this purpose?

• For cloud_admin user, the Launch tab is displayed even before approve
• General users do not see the Launch tab before approve

Thanks.

@sekinet

Can you please review the patch? Thanks

@yas @nakamurarts

Thank you for the patch. I think we should add phpunit tests.

• For cloud_admin user, the Launch tab is displayed even before approve
• General users do not see the Launch tab before approve

@yas @sekinet

Thank you all for your reviews.

I added tests based on the suggestion.

• https://git.drupalcode.org/project/cloud/-/merge_requests/1869/diffs?com...
• https://git.drupalcode.org/project/cloud/-/merge_requests/1869/diffs?com...

Please review, thank you.

@nakamurarts (cc: @sekine)

Thank you for the update. I don't think we should remove the permission launch cloud server template. It means we need to include two test cases: one for Drupal's administrator, the other one for a generic authenticated user.

@nakamurarts

On my second thought, the test case looks good.

Can you please fix the coding standard error? Thanks

→ https://www.drupal.org/pift-ci-job/2718783 →

@yas

Thank you for your review. I fixed the coding standard errors.

@nakamurarts

Thank you for the update. It looks good to me now. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

Automatically closed - issue fixed for 2 weeks with no activity.