Comply with Drupal coding standards (3)

$ cd /var/www/html; phpcs --standard=DrupalPractice --ignore=node_modules,bower_components,vendor --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,yaml,twig,json,ts,tsx,feature /var/www/html/web/profiles/contrib/cloud_orchestrator/ FILE: /var/www/html/web/profiles/contrib/cloud_orchestrator/cloud_orchestrator.profile -------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------------- 74 | WARNING | Unused variable $mes. -------------------------------------------------------------------------------------- FILE: /var/www/html/web/profiles/contrib/cloud_orchestrator/modules/cloud_orchestrator_tour/cloud_orchestrator_tour.info.yml ---------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------- 1 | WARNING | "Description" property is missing in the info.yml file ---------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/profiles/contrib/cloud_orchestrator/src/Installer/Form/ModuleConfigureForm.php ------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------ 72 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 96 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 103 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------------

Comments & Activities

Issue created by @phyllanthus
@nakamurarts opened merge request.
Status changed to Needs review over 1 year ago7:56am 9 May 2023
Comment over 1 year ago →
phyllanthus
The reported warnings with cloud_orchestrator/src/Installer/Form/ModuleConfigureForm.php (line 72, 96, 103 : "\Drupal calls should be avoided in classes, use dependency injection instead") have already been resolved in 4f65e044
Status changed to RTBC over 1 year ago9:14am 9 May 2023
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
@nakamurarts

Thank you for fixes. I applied the patch and ran phpcs. It looks good. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.
Status changed to Needs review over 1 year ago9:16am 9 May 2023
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
Status changed to RTBC over 1 year ago4:46pm 9 May 2023
Comment over 1 year ago →
🇺🇸United States baldwinlouie
@yas and @nakamuraarts, Thank you for the patch. It looks good to me.
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
@baldwinlouie

Thank you for your review. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.
Comment over 1 year ago →
System Message

yas → committed 95441186 on 6.x authored by nakamurarts →
Issue #3359013 by nakamurarts, yas, baldwinlouie: Comply with Drupal...
Status changed to Fixed over 1 year ago8:43pm 9 May 2023
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Comply with Drupal coding standards (3)

Problem/Motivation

Comments & Activities