Fix the access control on the launch template before approval (Add PHPUnit tests)

Issue created by @phyllanthus
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
367 pass
@nakamurarts opened merge request.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
367 pass
Status changed to Needs review over 1 year ago1:37am 23 August 2023
Comment over 1 year ago →
phyllanthus
First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
367 pass
Status changed to Needs work over 1 year ago1:29am 24 August 2023
Comment over 1 year ago →
🇯🇵Japan sekinet
@nakamurarts

I posted my comments, please see them. Thanks.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
367 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
367 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
367 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
367 pass
Comment over 1 year ago →
phyllanthus
@sekinet

Thank you for reviewing.
I corrected according to your suggestion. Please check.
Status changed to Needs review over 1 year ago9:07am 24 August 2023
Comment over 1 year ago →
phyllanthus
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
367 pass
Status changed to Needs work over 1 year ago2:48am 25 August 2023
Comment over 1 year ago →
🇯🇵Japan sekinet
@nakamurarts

I posted a minor comment. Could you please confirm?
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
367 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
367 pass
Status changed to Needs review over 1 year ago7:25am 25 August 2023
Comment over 1 year ago →
phyllanthus
@sekinet

Thank you for your review and suggestions.

I have made the corrections according to your suggestions,
could you please check again?
Comment over 1 year ago →
🇯🇵Japan sekinet
@nakamurarts
Thank you for your update. It looks good.

@yas
What do you think?
Status changed to RTBC over 1 year ago8:17am 25 August 2023
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
@sekinet

Thank you for your review.

@nakamurarts

Thank you for the update. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
367 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
367 pass
Comment over 1 year ago →
System Message

yas → committed 678403f7 on 6.x authored by nakamurarts →
Issue #3382746 by nakamurarts, yas, sekinet: Fix the access control on...
Comment over 1 year ago →
System Message

yas → committed c6f16771 on 5.x authored by nakamurarts →
Issue #3382746 by nakamurarts, yas, sekinet: Fix the access control on...
Status changed to Fixed over 1 year ago8:55am 25 August 2023
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix the access control on the launch template before approval (Add PHPUnit tests)

Problem/Motivation

Comments & Activities