- Status changed to Needs work
10 months ago 3:12pm 13 December 2023 - First commit to issue fork.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
10 months ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
10 months ago Waiting for branch to pass - Status changed to Needs review
10 months ago 3:52pm 13 December 2023 - 🇮🇳India ankithashetty Karnataka, India
MR is rebased and updated with #6 changes.
Noticed the below error:
/key_auth/src/KeyAuth.php --------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement 5 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statementsLooks like it was added in 🐛 Key Auth authenticator should query for users without access check Fixed . Was it deliberately added or can we clean it?
Thanks!
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
10 months ago Waiting for branch to pass - 🇮🇳India ankithashetty Karnataka, India
Updated MR with #9 suggestion.
Thanks!