- Issue created by @minoroffense
- Status changed to Needs review
about 1 year ago 8:10pm 6 December 2023 - 🇨🇦Canada minoroffense Ottawa, Canada
Here's a first attempt at this. Adds tokenize process, overrides the usesTokens method from the parent plugin and changes views.theme.inc to use the newly created getCaption() method.
- Status changed to Needs work
about 1 year ago 8:24pm 6 December 2023 The Needs Review Queue Bot → tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- Status changed to Needs review
about 1 year ago 8:32pm 6 December 2023 - Status changed to Needs work
about 1 year ago 9:06pm 6 December 2023 - 🇺🇸United States smustgrave
Thanks for opening
New return functions should be typehinted
Will need test coverageAlso new functions will need a change record.
Thanks!
- First commit to issue fork.
- 🇮🇳India ankithashetty Karnataka, India
Updated the MR with relevant functions doc comments. Retaining 'needs work' for tests and CR.
Thanks!
- 🇳🇱Netherlands Lendude Amsterdam
Added some comments. Other field allow this in these settings, so feels ok to allow this for the caption too.
As pointed out in #6, this needs test coverage
This should target the 'main' branch (called 11.x for now)
- First commit to issue fork.