Ottawa, Canada
Account created on 25 March 2007, almost 18 years ago
#

Merge Requests

More

Recent comments

🇨🇦Canada minoroffense Ottawa, Canada

Here's a 3.x version of the patch using the file_managed table instead.

🇨🇦Canada minoroffense Ottawa, Canada

I'd rather have the code adapt to help being available or not.

I created an MR for review that does that.

🇨🇦Canada minoroffense Ottawa, Canada

Updated patch to fix some lint issues. I'll give this a test to see if it works.

🇨🇦Canada minoroffense Ottawa, Canada

Thanks for the work. I finish it up and set the attribution in the commit for everyone.

🇨🇦Canada minoroffense Ottawa, Canada

I feel as though big coding standards changes like this should follow a core release or major versioning release of coder or something. We have versioning for core APIs why not versions of the coding spec.

We have dozens of individual modules to go and update now and every CI build is broken (including client releases where this spec has nothing to do with what they're trying to ship). Especially for what is arguably a cosmetic change to the spec.

Sure running the beautifier to autofix is great and all but it takes time to do that, time to explain to clients why everything is broken all of a sudden and more time to create follow up releases etc...

🇨🇦Canada minoroffense Ottawa, Canada

Here's a patch that uses the accept headers as decriebed in #25

Could be worked into the main issue of having a default format or on its own to leverage http headers to set the request format instead of that argument.

🇨🇦Canada minoroffense Ottawa, Canada

I tested it with our local sites and it appears to work. I'm using the latest xhprof dev module and the xhgui php profiler module. Running with PHP 8.2

I enabled the module as usual and then configured it.

I've attached the settings we use. Note the URL for the XHGui instance needs to be configured. We use a docker instance and it's docker network name is "xhgui" so we set the url to "http://xhgui"

You can see the nginx config we use for the xhgui instance: https://gitlab.com/dropfort/dropfort_build/-/tree/6.x/assets/development...

And this is the docker-compose file which brings it up. Maybe one of those may help with figuring out why it's not working.

https://gitlab.com/dropfort/dropfort_build/-/blob/6.x/assets/development...

And this is how we install xhprof into the container: https://gitlab.com/dropfort/dropfort_build/-/blob/6.x/assets/development...

🇨🇦Canada minoroffense Ottawa, Canada

I’m working on a 10.3 site today and I’ll figure out what’s up with xhgui.

🇨🇦Canada minoroffense Ottawa, Canada

We setup a view that outputs values into a table for time spent entries. The data element describes the value as seconds and the we use that to generate charts and other things.

Views strips the data element without the patch. We can’t use the raw number since we want to show the value in different formats. The display value is human friendly but the data element lets us bring along machine friendly info.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/data

🇨🇦Canada minoroffense Ottawa, Canada

This change does break the acquia_search module. Their setEventDispatcher needs to update to match. I'll reference that issue once I create it.

🇨🇦Canada minoroffense Ottawa, Canada

No worries. Glad it got in. And thanks for the attribution.

🇨🇦Canada minoroffense Ottawa, Canada

We have a pair of clients now where it just stops working. You can see the tracking code for a few requests then it’s gone. There’s something wrong. At a certain point there’s just no js added at all. No settings nothing.

Going to test a downgrade and see if that helps. And then compare versions to see what changed.

🇨🇦Canada minoroffense Ottawa, Canada

Likely going to need tests but figure get some eyes on it now in case something big needs changing.

I was contemplating adding checks that the langcodes were valid but I'd have to do that on render since it supports tokens and I didn't want to slow stuff down. Figure drupal will just fallback to default if the langcode is bad.

🇨🇦Canada minoroffense Ottawa, Canada

And I now realize this is fixed in 5.4.x+ :-/

Nm, sorry for the noise.

🇨🇦Canada minoroffense Ottawa, Canada

Here's a first attempt at this. Adds tokenize process, overrides the usesTokens method from the parent plugin and changes views.theme.inc to use the newly created getCaption() method.

🇨🇦Canada minoroffense Ottawa, Canada

Yes I was actually thinking that. I'm also on my way to VueConf in Toronto later this week. I was gonna roll a stable before going. Hoping to learn a few things to add into the module. Or add some related modules for some common UI elements (like a date picker or something).

🇨🇦Canada minoroffense Ottawa, Canada

Well you don’t need the files folder to store runs if you’re using this module. It would ship it into xhgui.

Also do you have the xhprof php plugin installed and enabled? php -m on the command line should show it if so. Or the output of phpinfo()

🇨🇦Canada minoroffense Ottawa, Canada

minorOffense made their first commit to this issue’s fork.

🇨🇦Canada minoroffense Ottawa, Canada

3.x branch and alpha are avaialble.

🇨🇦Canada minoroffense Ottawa, Canada

Going to mark this as fixed since the 3.x branch has an alpha. Feel free to reopen if you still have issues.

🇨🇦Canada minoroffense Ottawa, Canada

I created a 3.x branch for the D10 support and dropping D8. I haven't tested it yet but I'm working on a site that uses Flexslider that's being upgraded. Once I know it works I'll put a release in.

🇨🇦Canada minoroffense Ottawa, Canada

minorOffense made their first commit to this issue’s fork.

🇨🇦Canada minoroffense Ottawa, Canada

This is required by a client we share for their D10 upgrade. Can you please review.

🇨🇦Canada minoroffense Ottawa, Canada

Before merging any D10 changes I want to drop support for D8 and remove some references to jquery easing (they can't work in D9+).

I created an MR into the branch Rishi created.

I don't have an environment to test it in at the moment.

🇨🇦Canada minoroffense Ottawa, Canada

minorOffense made their first commit to this issue’s fork.

🇨🇦Canada minoroffense Ottawa, Canada

Thanks but the docs were outdated so I ended up just rewriting them.

🇨🇦Canada minoroffense Ottawa, Canada

Closing an unnecessary since we'll deprecate the D7 version shortly.

🇨🇦Canada minoroffense Ottawa, Canada

Closing an unnecessary since we'll deprecate the D7 version shortly.

🇨🇦Canada minoroffense Ottawa, Canada

Closing an unnecessary since we'll deprecate the D7 version shortly.

🇨🇦Canada minoroffense Ottawa, Canada

Closing an unnecessary since we'll deprecate the D7 version shortly.

🇨🇦Canada minoroffense Ottawa, Canada

No longer required. drush cget or vget can get the data we need.

🇨🇦Canada minoroffense Ottawa, Canada

Closing an unnecessary since we'll deprecate the D7 version shortly.

🇨🇦Canada minoroffense Ottawa, Canada

Closing an unnecessary since we'll deprecate the D7 version shortly.

🇨🇦Canada minoroffense Ottawa, Canada

This is already present in the D9+ version.

🇨🇦Canada minoroffense Ottawa, Canada

Closing an unnecessary since we'll deprecate the D7 version shortly.

🇨🇦Canada minoroffense Ottawa, Canada

Here's a patch in case.

🇨🇦Canada minoroffense Ottawa, Canada

The committed changes here missed the core key in the info file. It needs updating.

Production build 0.71.5 2024