- First commit to issue fork.
- Merge request !46Issue #3168014: TypeError: Argument 1 passed to Drupal\flag\TwigExtension\FlagCount::count() must implement interface β (Open) created by alorenc
- last update
about 1 year ago 46 pass - π΅π±Poland alorenc Wolsztyn, π΅π±
I have roll out patch !14 as MR request. I have added some small updates (spacing, type hinting)
- Status changed to Needs review
about 1 year ago 1:54pm 5 May 2023 - last update
about 1 year ago 46 pass - last update
about 1 year ago 46 pass - last update
about 1 year ago 46 pass - last update
about 1 year ago 46 pass - Status changed to RTBC
about 1 year ago 2:00pm 18 May 2023 - π¬π·Greece idimopoulos
Patch applies and works for us. Also, comments from #13 are addressed. Tests are green and applying.
+1 RTBC - πΊπΈUnited States droath
While dealing with a related issue, I realized the importance of conducting an access check. Personally, I believe it would be more logical to perform this check early in the process. Surprisingly, as I worked on resolving this matter, it also ended up indirectly addressing the problem discussed in this thread.
https://www.drupal.org/project/flag/issues/3383006 π Missing Access Control Check Prior to Rendering Link Active
- Open on Drupal.org βCore: 9.5.x + Environment: PHP 7.3 & MySQL 5.7last update
5 months ago Waiting for branch to pass - π§πΎBelarus alexdoma
I got an error message after adding this patch
TypeError: Drupal\flag\Plugin\ActionLink\AJAXactionLink::__construct(): Argument #5 ($csrfToken) must be of type Drupal\Core\Access\CsrfTokenGenerator, Symfony\Component\HttpFoundation\Request given
patch from #14 updated
- Status changed to Active
5 months ago 8:14am 15 January 2024 - last update
5 months ago 45 pass, 2 fail - π¦πΊAustralia admirernepali
Still did not work for version 9.5.11.
I am on route to upgrade to 10 from 8. I will post here if Version 10 does not require this below patch.I still had to apply this patch: https://www.drupal.org/files/issues/2020-11-08/flag_count_3180434.patch β
Although that issue ( https://www.drupal.org/project/flag/issues/3180434 β ) was closed as duplicate of this issue.
- First commit to issue fork.
- Open on Drupal.org βCore: 9.5.x + Environment: PHP 7.3 & MySQL 5.7last update
about 19 hours ago Waiting for branch to pass