TypeError: Argument 1 passed to Drupal\flag\TwigExtension\FlagCount::count() must implement interface

I have roll out patch !14 as MR request. I have added some small updates (spacing, type hinting)

Patch applies and works for us. Also, comments from #13 are addressed. Tests are green and applying.
+1 RTBC

While dealing with a related issue, I realized the importance of conducting an access check. Personally, I believe it would be more logical to perform this check early in the process. Surprisingly, as I worked on resolving this matter, it also ended up indirectly addressing the problem discussed in this thread.

https://www.drupal.org/project/flag/issues/3383006 🐛 Missing Access Control Check Prior to Rendering Link Active

I got an error message after adding this patch
TypeError: Drupal\flag\Plugin\ActionLink\AJAXactionLink::__construct(): Argument #5 ($csrfToken) must be of type Drupal\Core\Access\CsrfTokenGenerator, Symfony\Component\HttpFoundation\Request given

patch from #14 updated

Still did not work for version 9.5.11.
I am on route to upgrade to 10 from 8. I will post here if Version 10 does not require this below patch.

I still had to apply this patch: https://www.drupal.org/files/issues/2020-11-08/flag_count_3180434.patch →

Although that issue ( https://www.drupal.org/project/flag/issues/3180434 → ) was closed as duplicate of this issue.

MR needs rebase

immaculatexavier → changed the visibility of the branch 3168014- to hidden.

immaculatexavier → changed the visibility of the branch 3168014- to active.

immaculatexavier → changed the visibility of the branch 3168014- to hidden.

prem suthar → made their first commit to this issue’s fork.

alorenc → changed the visibility of the branch 3168014-typeerror-argument-1 to hidden.

alorenc → changed the visibility of the branch 3168014-typeerror-argument-1 to active.

The MR is rerolled. Removing tag.

The latest patch from the MR failed to apply to either 8.x-4.0-beta6 or 8.x-4.x.

I don't know the underlying reason why the MR isn't applying, although I the line numbers are obviously off. I manually created a patch from the changes in the branch and this one does apply.

knyshuk.vova → made their first commit to this issue’s fork.

#41 accidentally deletes the flag-count-text.html.twig template, that's causing an error.

amanire, I have also noticed an issue where the patch (from MR > Download > Patches) from the merge request is not applying, but the diff (from MR > Download > Plain diff) applies successfully.

As for now, the MR 46 diff is applied correctly.

Thank you @knyshuk.vova for clarifying and working on the MR! I was able to successfully apply the diff patch from the MR on beta6.

And after tracking down some errors in custom module code related to this beta6 change record → , I was able to get it working without errors.

ivnish → changed the visibility of the branch 8.x-4.x to hidden.

I think we need some tests

knyshuk.vova’s picturenew
Comment#43knyshuk.vova commented 8 days ago
#41 accidentally deletes the flag-count-text.html.twig template, that's causing an error.

amanire, I have also noticed an issue where the patch (from MR > Download > Patches) from the merge request is not applying, but the diff (from MR > Download > Plain diff) applies successfully.

As for now, the diff from Merge request !46 is applied correctly for 8.x-4.0-beta6.

Can confirm, MR works as a local patch.

knyshuk.vova’s picturenew
Comment#43knyshuk.vova commented 8 days ago
#41 accidentally deletes the flag-count-text.html.twig template, that's causing an error.

amanire, I have also noticed an issue where the patch (from MR > Download > Patches) from the merge request is not applying, but the diff (from MR > Download > Plain diff) applies successfully.

As for now, the diff from Merge request !46 is applied correctly for 8.x-4.0-beta6.

Can confirm, MR works as a local patch.