Wolsztyn, 🇵🇱
Account created on 31 January 2019, over 6 years ago
#

Merge Requests

More

Recent comments

🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱

alorenc made their first commit to this issue’s fork.

🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱

alorenc created an issue.

🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱

For some reason, I cannot set credits: you need to be a maintainer of the module to make changes. Leaving it as “Reviewed and tested by the community.”

🇵🇱Poland alorenc Wolsztyn, 🇵🇱

Approved and merged

🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱

alorenc created an issue.

🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱

I performed manual tests—import and export—and did not notice any issues.

🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱

alorenc created an issue.

🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱

alorenc created an issue. See original summary .

🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱

The module is not yet stable, so I assume that we do not need an update script.

🇵🇱Poland alorenc Wolsztyn, 🇵🇱

alorenc made their first commit to this issue’s fork.

🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱

alorenc changed the visibility of the branch 11.x to hidden.

🇵🇱Poland alorenc Wolsztyn, 🇵🇱

alorenc created an issue.

🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱

alorenc created an issue.

🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱

alorenc changed the visibility of the branch 1.2.x to hidden.

🇵🇱Poland alorenc Wolsztyn, 🇵🇱

alorenc created an issue.

🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱

alorenc changed the visibility of the branch 3547582-link-widget-placeholderurl to hidden.

🇵🇱Poland alorenc Wolsztyn, 🇵🇱

alorenc created an issue.

🇵🇱Poland alorenc Wolsztyn, 🇵🇱
🇵🇱Poland alorenc Wolsztyn, 🇵🇱

alorenc created an issue.

🇵🇱Poland alorenc Wolsztyn, 🇵🇱

babel_update_8001 removes duplication
Duplicated are not longer created

🇵🇱Poland alorenc Wolsztyn, 🇵🇱

I performed manual tests: hook removes OG menus. I uninstalled and reinstalled the module a few times in order to test the batch process. I also updated a few menu items. It looks fine, thanks.

🇵🇱Poland alorenc Wolsztyn, 🇵🇱

alorenc created an issue.

🇵🇱Poland alorenc Wolsztyn, 🇵🇱

I can see warning messages during the import if any occur.

🇵🇱Poland alorenc Wolsztyn, 🇵🇱

Is there any reason why the README.md file was not updated as well?

🇵🇱Poland alorenc Wolsztyn, 🇵🇱

I can still see many references to the "4.32.2" library version.

🇵🇱Poland alorenc Wolsztyn, 🇵🇱

I checked the Field Group module and did not find any related code, except for "window.location.hash," but this is not what we want here.

🇵🇱Poland alorenc Wolsztyn, 🇵🇱

It is a fair argument, condition already exists.

Looks fine, Cache Tags were added

🇵🇱Poland alorenc Wolsztyn, 🇵🇱

I have added a comment to MR

🇵🇱Poland alorenc Wolsztyn, 🇵🇱

Another argument against this approach is
If I copy a string from "Source string" to "Translated string" in Excel, the protection is copied as well. I am no longer able to update the value in "Translated string." I think the copy functionality is crucial for speeding up translation.

🇵🇱Poland alorenc Wolsztyn, 🇵🇱

Update
It did not work in case I tried to download the language that was exported before applying the changes.

🇵🇱Poland alorenc Wolsztyn, 🇵🇱

Users can export data in four formats. For example, in the case of CSV, it is not possible to protect or hide columns.
I opened an XLSX file with LibreOffice (v24.2), and it did not work either.

I do not think it is a good idea to change that because:

  • It will not work for all formats.
  • It probably works only with Microsoft Office.
  • A user can still modify even the hidden columns.

Instead of that, my suggestion is to:

  • improve import validation and add a warning in case an ID is not found.
  • Update "ID" to something clearer, such as "Reference ID."
  • Add a clear description on the /admin/config/regional/babel/export and /admin/config/regional/babel/import pages.
🇵🇱Poland alorenc Wolsztyn, 🇵🇱

Hook was updated, it looks fine

🇵🇱Poland alorenc Wolsztyn, 🇵🇱

alorenc changed the visibility of the branch 3230135-webform-referenced-for-paragrphs to hidden.

🇵🇱Poland alorenc Wolsztyn, 🇵🇱

I noticed the same issue. I am going to roll the patch 11 to MR

Production build 0.71.5 2024