Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
Account created on 31 January 2019, about 6 years ago
#

Merge Requests

More

Recent comments

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

alorenc โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

probably we could add @deprecated to RdfUriGenerator but I am leaving that to maintainer of this module

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

Created MR based on the previously provided patch.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

alorenc โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

We have a custom ActionLinkType, and I had to provide four parameters to lazy_builder (flag.link_builder:build) - view mode.
At the same time, I had to update getAsFlagLink method, as ActionLinkTypePluginInterface requires $view_mode as well.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

Okay, I think we can add a module setting that will determine the usage of the queue.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

alorenc โ†’ created an issue.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

It works as expected; the issue was related to customization, which had to be rewritten after the module upgrade.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

It looks like the issue is related to my project.
The following code sets view_mode,
https://git.drupalcode.org/project/flag/-/blob/8.x-4.x/src/ActionLink/Ac...

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

alorenc โ†’ created an issue.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

alorenc โ†’ changed the visibility of the branch 3168014-typeerror-argument-1 to active.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

alorenc โ†’ changed the visibility of the branch 3168014-typeerror-argument-1 to hidden.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

I donโ€™t think this is a good idea.
If you want to clear autosubmit, it means that you probably donโ€™t want to use this module.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

alorenc โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

Please see the attached image. The decision was made by the eTransaction team. I am not happy about it because it complicates testing, but it is what it is.

You can find that on https://language-tools.ec.europa.eu/#documentation
"Guidelines on integrating eTranslation in your web pages", next "How to request translations using the eTranslation webservice" and "SecuredWSEndPointHandlerService"

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

alorenc โ†’ created an issue.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

Looks fine, Ajax calls do not generate infinite errors.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

This has some side effects. If I log in again inside the second tab, the system will no longer update messages in the first tab.
I don't know which option is better

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

+ for GitLab CI. Could this be merged? It would be highly beneficial for addressing future tickets.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

I have exported configuration before applying the patch, otherwise it is fine.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

I got the following errors

'views.view.calendar:display.by_month.display_options.pager.options.display_reset' => 'variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData'
'views.view.calendar:display.by_month.display_options.pager.options.use_previous_next' => 'variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData'
'views.view.calendar:display.by_week.display_options.pager.options.display_reset' => 'variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData'
'views.view.calendar:display.by_week.display_options.pager.options.use_previous_next' => 'variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData'

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

Rolled 2765065-10.3.x-154.diff to Drupal 10.4.x

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

Looks ok on my side, triggered
composer require 'drupal/field_group:^4.0@alpha'
and next
composer require 'drupal/field_group_nav:^1.0'

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

I performed some manual test based on 4.0.0-alpha1 module, looks ok.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

alorenc โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

Made changes to gitlab-ci.yml file and created https://www.drupal.org/project/field_group_nav/releases/1.0.2 โ†’

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

alorenc โ†’ created an issue.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

alorenc โ†’ created an issue.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

It has been changed during https://www.drupal.org/project/field_group_nav/issues/3473277 ๐Ÿ“Œ Provide tests Active

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

I do not see the issue.

Here are the steps I followed:
* I created a thread and was redirected to private-messages/7.
* I deleted thread 7 and was redirected to private-messages.
* When I visited private-messages/7, the system displayed a 404 error, which is correct because the thread had been removed.

To start a new discussion, I need to visit /private-message/create and select a member. I can also choose a user to an earlier delete thread.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

I think we can close this ticket. @drupalfan2 Are you ok with it?

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

The patch works correctly for me.
I tested inside the private_message module, see #3331865. The message editor receives focus, and the interface automatically scrolls down to this element.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

The patch from #3494327 functions correctly for me.
When I click on a thread within the inbox block, the message editor receives focus, and the interface automatically scrolls down to this element.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

patch #6 removes array_splice so the idea is similar to https://www.drupal.org/project/private_message/issues/3492289 ๐Ÿ› Wrong usage of array_splice Active

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

Please see #3492289 as it could be related

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

alorenc โ†’ created an issue.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

alorenc โ†’ created an issue.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

Hi zenimagine,

I think you can try to update the configuration: visit /admin/structure/private-message/private-message-thread/form-display as admin and hide the "Subject" field from view.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

Looks good, thanks

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

Looks good, Thanks!

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

alorenc โ†’ created an issue.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ
๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

Thank you for your help!

I worked on #3490456, and I have a feeling that maybe we can remove the 'triggerCommands' function. It depends on how extensive a refactoring we want to undertake.

My suggestion is to put this on hold. Yes, I asked for that, and I apologize for changing the approach.

Let's wait for some time, but your work definitely deserves recognition and credit!

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

Looks good, moving to RTBC.

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

Your error is handled by https://www.drupal.org/project/file_url/issues/3490692 ๐Ÿ› PHP error FileUrlGenerator Active , see https://git.drupalcode.org/project/file_url/-/merge_requests/8#note_419768

๐Ÿ‡ต๐Ÿ‡ฑPoland alorenc Wolsztyn, ๐Ÿ‡ต๐Ÿ‡ฑ

alorenc โ†’ created an issue.

Production build 0.71.5 2024