Contrib.social

Automated Drupal 11 compatibility fixes for private_message_flood

Open on Drupal.org →
Created on 24 March 2024, over 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Needs review

Version

2.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • Comment over 1 year ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

    Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

    The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-127659

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.9
    3. palantirnet/drupal-rector: 0.20.1
  • Merge request !4Automated Project Update Bot fixes → (Merged) created by project update bot
  • Status changed to Needs work 5 months ago
  • Comment 5 months ago →
    🇷🇴Romania claudiu.cristea Arad 🇷🇴

    core_version_requirement needs also to be adapted

  • First commit to issue fork.
  • Pipeline finished with Failed
    about 1 month ago
    #554046
  • Pipeline finished with Success
    about 1 month ago
    #554074
  • Comment about 1 month ago →
    🇵🇹Portugal saidatom Lisbon
  • Comment about 1 month ago →
    🇵🇱Poland alorenc Wolsztyn, 🇵🇱
  • Comment about 1 month ago →
    🇵🇱Poland alorenc Wolsztyn, 🇵🇱

    Added some remarks/questions to MR

  • Pipeline finished with Failed
    about 1 month ago
    Total: 139s
    #556863
  • Pipeline finished with Success
    about 1 month ago
    Total: 140s
    #556864
  • Pipeline finished with Success
    28 days ago
    Total: 216s
    #558438
  • Comment 28 days ago →
    🇵🇱Poland alorenc Wolsztyn, 🇵🇱
  • Comment 28 days ago →
    🇮🇳India vinodhini.e chennai

    Hi, I have installed this module on Drupal 11.2.2.
    It was not compatible with Drupal 11 – also facing coding standards (PHPCS) issues.
    After merging the 4.x branch, it became compatible.
    The PHPCS issues have also been fixed. Thanks.

  • Pipeline finished with Success
    24 days ago
    Total: 140s
    #562185
  • Comment 24 days ago →
    🇵🇹Portugal saidatom Lisbon
  • Comment 24 days ago →
    🇵🇱Poland alorenc Wolsztyn, 🇵🇱

    alorenc → changed the visibility of the branch 3433991-automated-drupal-11 to hidden.

  • Comment 24 days ago →
    🇵🇱Poland alorenc Wolsztyn, 🇵🇱

    I have performed some tests, and it generates a fatal error on both versions of private_messages (v3 and v4).

    private_message v4
    Fatal error: Declaration of Drupal\private_message_flood\Plugin\PrivateMessageConfigForm\PrivateMessageFloodPrivateMessageConfigForm::create(Symfony\Component\DependencyInjection\ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) must be compatible with Drupal\private_message\Plugin\PrivateMessageConfigForm\PrivateMessageConfigFormBase::create(Symfony\Component\DependencyInjection\ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition):

    private_message v3
    Fatal error: Declaration of Drupal\private_message_flood\Plugin\PrivateMessageConfigForm\PrivateMessageFloodPrivateMessageConfigForm::validateForm(array &$form, Drupal\Core\Form\FormStateInterface $formState) must be compatible with Drupal\private_message\Plugin\PrivateMessageConfigForm\PrivateMessageConfigFormBase::validateForm(array &$form, Drupal\Core\Form\FormStateInterface $formState): void in /var/www/html/web/modules/repos/private_message_flood/src/Plugin/PrivateMessageConfigForm/PrivateMessageFloodPrivateMessageConfigForm.php on line 200

    In both cases we have
    Error: Call to undefined function Drupal\private_message_flood\Plugin\PrivateMessageConfigForm\user_role_names() in Drupal\private_message_flood\Plugin\PrivateMessageConfigForm\PrivateMessageFloodPrivateMessageConfigForm->buildForm() (line 81 of modules/repos/private_message_flood/src/Plugin/PrivateMessageConfigForm/PrivateMessageFloodPrivateMessageConfigForm.php).
    which makes sense as user_role_names is no longer aviable in D11

    First, we need to resolve/merge https://www.drupal.org/project/private_message_flood/issues/3501011 📌 Private message 4 compatibility fixes Active and issues should disappear.

  • Comment 24 days ago →
    🇵🇱Poland alorenc Wolsztyn, 🇵🇱

    Moved to “Needs Work” because the current state generates a fatal error.

  • Comment 5 days ago →
    🇵🇹Portugal dxvargas

    The issue https://www.drupal.org/project/private_message_flood/issues/3501011 📌 Private message 4 compatibility fixes Active is now merged.

  • Comment 5 days ago →
    🇵🇹Portugal dxvargas

    The MR is green now, after merging 2.x into the branch from here.
    Review please!

  • Comment 5 days ago →
    🇵🇱Poland alorenc Wolsztyn, 🇵🇱
  • Comment 5 days ago →
    🇵🇱Poland alorenc Wolsztyn, 🇵🇱
  • Comment 5 days ago →
    🇵🇱Poland alorenc Wolsztyn, 🇵🇱

    it works fine , thanks

  • Comment 4 days ago →
    🇵🇹Portugal dxvargas

    Merged, thank you all!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024