- Issue created by @minoroffense
- π¨π¦Canada minoroffense Ottawa, Canada
minorOffense β changed the visibility of the branch 11.x to hidden.
- Status changed to Needs review
11 months ago 6:47pm 15 February 2024 - π¨π¦Canada minoroffense Ottawa, Canada
Likely going to need tests but figure get some eyes on it now in case something big needs changing.
I was contemplating adding checks that the langcodes were valid but I'd have to do that on render since it supports tokens and I didn't want to slow stuff down. Figure drupal will just fallback to default if the langcode is bad.
- π¨π¦Canada minoroffense Ottawa, Canada
Here's what the field looks like in Views.
- Status changed to Needs work
11 months ago 8:13am 17 February 2024 - π³π±Netherlands Lendude Amsterdam
Sounds a little edge case to me, don't think it makes the 80% criterium, especially with token support thrown in. Might be more user friendly with a select element showing available languages
It would need some things I think:
- should only be shown on multi-lingual sites
- yeah validating if we have valid input sounds good, just hoping it falls back sounds bad
- tests
- a schema update
- an upgrade path for the schema change
- a test for the upgrade path