- Issue created by @roshni27
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 4:59am 10 July 2023 - 🇮🇳India roshni27
Some issues are pending because of reading purpose. Please review the patch.
- Status changed to Needs work
over 1 year ago 2:54pm 21 July 2023 - 🇵🇭Philippines roberttabigue
Hi @roshni27,
I reviewed the changes and confirmed the Patch was applied cleanly to the Dropfort Update module against 2.1.x-dev on Drupal 9.5.10.
Checking patch LICENSE.txt... Checking patch dropfort_update.module... Applied patch LICENSE.txt cleanly. Applied patch dropfort_update.module cleanly.
However, I'm still moving this to Needs Work for now due to pending errors:
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/dropfort_update/README.md ----------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 16 WARNINGS AFFECTING 16 LINES ----------------------------------------------------------------------------------------------------- 6 | WARNING | Line exceeds 80 characters; contains 135 characters 15 | WARNING | Line exceeds 80 characters; contains 88 characters 25 | WARNING | Line exceeds 80 characters; contains 319 characters 30 | WARNING | Line exceeds 80 characters; contains 144 characters 32 | WARNING | Line exceeds 80 characters; contains 597 characters 34 | WARNING | Line exceeds 80 characters; contains 237 characters 36 | WARNING | Line exceeds 80 characters; contains 172 characters 39 | WARNING | Line exceeds 80 characters; contains 298 characters 41 | WARNING | Line exceeds 80 characters; contains 117 characters 45 | WARNING | Line exceeds 80 characters; contains 94 characters 47 | WARNING | Line exceeds 80 characters; contains 168 characters 48 | WARNING | Line exceeds 80 characters; contains 167 characters 55 | WARNING | Line exceeds 80 characters; contains 415 characters 57 | WARNING | Line exceeds 80 characters; contains 396 characters 62 | WARNING | Line exceeds 80 characters; contains 307 characters 63 | WARNING | Line exceeds 80 characters; contains 92 characters ----------------------------------------------------------------------------------------------------- Time: 113ms; Memory: 10MB
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig dropfort_update
Thank you!
- Status changed to Needs review
over 1 year ago 6:45am 24 July 2023 - 🇮🇳India mrinalini9 New Delhi
Updated patch #2 by addressing #3, please review it.
Thanks!
- Status changed to Closed: outdated
over 1 year ago 3:51pm 24 July 2023 - 🇨🇦Canada minoroffense Ottawa, Canada
Thanks but the docs were outdated so I ended up just rewriting them.