Automated Drupal 10 compatibility fixes

Hi,

I just update flexslider to the d10 compatible dev version. Unfortunately the Upgrade Status module refuses putting is d10 Compatible. 4 more issues are found . see attached file.

Apparently there is still a little work left in order to get ik compatible

@bart lambert : I cannot reproduce your issues. Did you use the merge request !4 in #7 ?

tests/modules/flexslider_library_test/flexslider_library_test.info.yml needed version 10, too

Please review the updated Merge request !4

Hi,

Thanks for pointing it out to me! I did not.
Applied the patches and now it all works fine!

Thanks!!!

Maybe somebody could add an new version update.

I applied the patches and manually updated the info.yml files to include version 10 and I got it to pass upgrade status and install on a version 10 site but it still didn't work.
It was throwing .once JS errors because of jquery.once not being in version 10 (I had already changed dependencies from core/jquery.once to core/once but was still getting .once JS errors).
I copied jquery.once from version 9 core to my theme JS folder, added jquery.once files to theme libraries.yml and then my flex slider block worked.

I applied the patches and manually updated the info.yml files to include version 10 and I got it to pass upgrade status and install on a version 10 site but it still didn't work.
It was throwing .once JS errors because of jquery.once not being in version 10 (I had alredy changed dependencies from core/jquery.once to core/once but was still getting .once JS errors).
I copied jquery.once from version 9 core to my theme JS folder, added jquery.once files to theme libraries.yml and then my flex slider block worked.

I patched my installation of flexslider on my Drupal 10 site and no slides appear.

all slides ( li ) remain on "display: none".

I get no javascript/jquery errors.

I tried #13 but it didn't help.

It seems the jquery doesn't get executed. what else can I look into ?

I am not very well versed in applying patches and merge requests so I'm a bit confused reading this thread.

@bart lambert writes that he applied the patches. Are those the patches in #2 or #3 or both or neither?

@sleitner writes Did you use the merge request !4 in #7. What does that mean? Can a merge request be applied like a patch?

Any guidance would be much appreciated.

@bill_redman You can download a patch file from the merge request: "Code" button -> Download plain diff and apply it

Removed core:8.x in all submodules

@sleitner - Thank you for answering my question. Each day, learn a little bit more.

@bill_redman : I applied all changes under "Merge request4!"

@bart lambert - Thanks, the changes under merge request !4 are what I applied when I said 'the patch'.

This isn't working, needs work!

The arrow function () => { ... } used in the code was replaced with a regular function function() { ... }. This change was made to ensure compatibility with older versions of JavaScript or libraries that may not support arrow functions.
The element selection within the once function was updated. Previously, $(once("flexslider", #${id}, context)) was used to select elements, but it was changed to $(this) to refer to the current element being processed. This change allows for better clarity and ensures that the correct elements are targeted for manipulation.

This is now ready to be tested!

https://git.drupalcode.org/project/flexslider/-/merge_requests/4.diff

@Rishi Kulshreshtha, changes from comment #22 works as expected.

changes from comment #22 work as expected.

Patch from diff of 22.

Can't get the patch from diff to apply.

Some sort of composer issue. Now the patch applies, but I am requiring the tag, and composer is grabbing dev...

But at least the patch works.

ddev composer require 'drupal/flexslider:^2.0'
./composer.json has been updated
Running composer update drupal/flexslider
Gathering patches for root package.
Removing package drupal/flexslider so that it can be re-installed and re-patched.
  - Removing drupal/flexslider (dev-2.x 6d1ae5f)
Deleting /var/www/html/web/modules/contrib/flexslider - deleted
Loading composer repositories with package information
Warning from https://packages.drupal.org/lenient: The Drupal lenient endpoint has been deprecated and does not support Drupal 10. Use mglaman/composer-drupal-lenient. See https://www.drupal.org/composer/lenient for more information.
Info from https://repo.packagist.org: #StandWithUkraine
Updating dependencies
Nothing to modify in lock file
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
  - Syncing drupal/flexslider (dev-2.x 6d1ae5f) into cache
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
  - Installing drupal/flexslider (dev-2.x 6d1ae5f): Cloning 6d1ae5f3ba from cache
  - Applying patches for drupal/flexslider
    https://git.drupalcode.org/project/flexslider/-/merge_requests/4.diff (D10-2)

Generating autoload files
101 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
phpstan/extension-installer: Extensions installed
Not scaffolding files for drupal/flexslider, because it is not listed in the element 'extra.drupal-scaffold.allowed-packages' in the root-level composer.json file.
No security vulnerability advisories found

@amaria, @minorOffense, @ryanwebpage, @ClassicCut, @spotzero please get a D10 version released.

Before merging any D10 changes I want to drop support for D8 and remove some references to jquery easing (they can't work in D9+).

I created an MR into the branch Rishi created.

I don't have an environment to test it in at the moment.

+1 RTBC

I'd like to confirm that patch #25 works perfectly with latest Drupal 10 verison using https://github.com/mglaman/composer-drupal-lenient

Hello,
is that possible to get a D10 new version released?
Thanks

I am also hoping for an official release for D10 soon. Thank you

@minorOffense
Could you please release a new D10 version of the module?
2 month already passed from the last updates...

Automatically closed - issue fixed for 2 weeks with no activity.