- Issue created by @just_like_good_vibes
- last update
8 months ago 31 pass - Status changed to Needs review
8 months ago 9:47pm 4 April 2024 - πΊπΈUnited States smustgrave
Setting up a local site for testing and was on 10.3.x and I couldn't add a server without getting fatal error
MR does fix the problem. Almost tempted to say this is a critical as doesn't seem search_api_solr will work on 10.3
- Status changed to Needs work
7 months ago 6:07am 22 April 2024 - π©πͺGermany mkalkbrenner π©πͺ
Thanks for the patch. But as explained on the project page, it doesn't get tested on drupal.org CI.
You need to create a PR for https://github.com/mkalkbrenner/search_api_solr to run the entire test suite. And I want to see if this patch breaks anything in the still supported versions. - π«π·France just_like_good_vibes PARIS
Hello,
thank you for pointing out the MR to do.
But i was trying to open the MR on github, but i just saw you done it 1h ago :)
I guess for now i have nothing to do?
thank you -
mkalkbrenner β
committed 89340c7d on 4.x
Issue #3438719 by just_like_good_vibes, mkalkbrenner: Compatibility with...
-
mkalkbrenner β
committed 89340c7d on 4.x
- Issue was unassigned.
- Status changed to Fixed
7 months ago 9:36am 22 April 2024 - π©πͺGermany mkalkbrenner π©πͺ
Yes, I did it and the tests passed :-)
Thanks for your help.
Automatically closed - issue fixed for 2 weeks with no activity.
- π¨π¦Canada minoroffense Ottawa, Canada
This change does break the acquia_search module. Their setEventDispatcher needs to update to match. I'll reference that issue once I create it.