The ordering of content type is broken

I was only able to reproduce this issue in Drupal9.5.10, in Drupal10 it is not reproducible. I tested the above patch in D9.5.10, it works fine. I have attached screenshots of admin toolbar sequence both before and after application of patch.

Hi,
Tested #2 patch on Drupal version 9.5.11 and 10.0
The patch was applied successfully on both version

Testing Steps:
Set up the Drupal and theme
Add Admin toolbar
Go to admin/config/user-interface/admin-toolbar-tools and set the "Maximum number of bundle sub-menus to display" value to 4
Add 6 content types, named as a, b, c, d, e, f
Look at the "content-type" under "structure", and you will find that the displayed content type is not sorted
Apply the shared patch & reverify the results.

Test Result:
For D 9.5- The patch was applied successfully, and the ordering of content type broken issue is Fixed
For D 10- The patch was applied successfully, but the issue not fixed.

Screenshots are attached for reference
Moving to Needs Work

I was able to replicate the issue in both Drupal 10.1.6 and Drupal 9.5.0, but I couldn't successfully apply the provided patch in either of them.

Patch worked fine for me as well. Created an issue fork. Marking as RTBC.

Pushed some changes to the MR:

- We need accessCheck(FALSE) since these are built during cache rebuild, access is checked when menu items are rendered
- We don't need to check if weight exists, it'll silently do nothing if it doesn't
- We can improve this further by sorting by label after weight. This helps when for example all vocabularies have the same weight - they'll be queried alphabetically.

Tested in Drupal 10.2 . Still the ordering is not right. Attached the image
Order displayed is Article , basic a , b ...
Im bit confused here , Should this be alphabetically ordered?

Also gave the latest commit another look and I share divya.sejekan's confusion.

Ideally, shouldn't the entries in the menu be in the same order the entities would be on the entity list page? A.k.a. using the NodeType sort() function?

Re #14 and #15 this has to be generic to all content entity types, not just node types. Currently the MR sorts by weight, then label. IMO the after patch is closer to what is expected than the before so putting this back into needs review.

A.k.a. using the NodeType sort() function?

What is that?

This was fixed in 🐛 Max Bundles not being honored Fixed