Update eslint prettier configuration

Wim Leers → credited larowlan → .

Thanks, @DanielVeza! Excited to see you here! 😄

Per @larowlan, we should first land 📌 Add eslint and type checking to CI jobs Needs work to avoid the need to redo this in the future.

📌 Add eslint and type checking to CI jobs Needs work is in, meaning this is now unblocked!

Mithun S → made their first commit to this issue’s fork.

I've found MR contains some unexpected changes.
Like src/App.tsx

Also lint:fix show failures.

I also see existing `"format": "prettier --write .",` task in package.json

Should we keep it?

finnsky → changed the visibility of the branch 3452828-prettier to hidden.

I've created new PR.

- It should only affect js changes.
- We need to create follow up issue for stylelint and yaml etc. Because current `npm run format` still fixes public and MD and CSS files.

There were some pipeline failures that I was looking into only to re-run the tests and they were fine. In each case it was because the project directory could not be found, something that would not be caused by changes in either of the merge requests.

While I'm partial to the @finnsky MR #78 because it only changes the JS, the npm run format command still runs on non-js files. This means someone wanting to use format will have files changed that they haven't even edited. We should either include all file types or limit the types changed by format

@finnsky: Could you address #18? 😊 🙏 Would love to see this land!

I have weird deja vu :)

https://www.drupal.org/project/drupal/issues/3409048#comment-15525622 🐛 Configure postcss formatting after stylelint and stylelint-config-standard update Fixed
Linter issues aren't rebase friendly.

I will reapply changes in new 0.x based branch and let's create followup for CSS and MD

finnsky → changed the visibility of the branch 3452828-eslint-prettier to hidden.

#20: hah!

I'm fine with doing additional things in follow-ups, but would like to see @bnjmnm's feedback in #18 addressed. That doesn't require Doing All The Things in this issue — an alternative can be to restrict what npm run format does. Could you do that, @finnsky? 🤞

Removed format for now. We need to configure linter + prettier for css and other files.

@bnjmnm you did the last round of review for this in #18 — could you give this another pass? 🙏

Removed format for now

Not sure that's a good idea either - if GitlabCI + eslint is enforcing prettier formatting, we shouldn't require contributors to fix all of those things manually when a formatter is right there I think it's best to go with my suggestion in #18 and have the formatter only act on JS files for the time being, while also configuring ESLint to enforce prettier formatting. That's what I have in the <a href="https://git.drupalcode.org/project/experience_builder/-/merge_requests/124#note_349548">3452828-js-only-eslint-with-format </a> MR

bnjmnm → credited hooroomoo → .

OMG YES! So glad this is in! 😄👍

Wim Leers → closed merge request !78

Wim Leers → closed merge request !44

Wim Leers → closed merge request !77

Automatically closed - issue fixed for 2 weeks with no activity.