merge node.*.css files into node.admin.css

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Hiding patches.

The MR merges the node preview CSS into node.css but leaves the library intact, I don't see a reason to merge the preview CSS - it's only used on preview, which is in a controller and attaches the preview library anyway.

It seems like node.admin.css, which only contains a background colour, could possibly be removed altogether rather than merged?

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Mithun S → made their first commit to this issue’s fork.

Mithun S → changed the visibility of the branch 2421365-merge-node.css-files to hidden.

tried several patches bot not applied create my own MR please check added all node folder css inside node.admin.css

I think I'm missing something, but why exactly do we want to combine all CSS into a single file? Currently these CSS files are split into separate libraries (although node.module.css is in 2 different libraries) which are added in different parts of the CMS depending on where they're needed. Combining all CSS into 1 file will mean adding CSS to places that it's not needed. Isn't it better to only add it where it's needed?

We also have many themes overriding or extending these libraries to add their own CSS, we would have to very carefully coordinate releases between all of these otherwise there will be visual regressions. Furthermore, it means contrib would have to have a new major/minor targeting the specific core release this is changed in.

The effort doesn't seem worth it IMO, what are we trying to gain here? Even though the CSS is all admin-ish related, it's for very different use cases.