- ๐ฎ๐ณIndia Gauravvv Delhi, India
Gauravvvv โ made their first commit to this issueโs fork.
- Merge request !8191merged node.admin.css, node.module.css, node.preview.css into node.admin.css file โ (Open) created by Unnamed author
- Status changed to Needs review
about 1 month ago 3:20am 27 May 2024 - Status changed to Needs work
about 1 month ago 3:25am 27 May 2024 The Needs Review Queue Bot โ tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request โ . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- Status changed to Needs review
about 1 month ago 7:02am 27 May 2024 - ๐ฌ๐งUnited Kingdom catch
Hiding patches.
The MR merges the node preview CSS into node.css but leaves the library intact, I don't see a reason to merge the preview CSS - it's only used on preview, which is in a controller and attaches the preview library anyway.
It seems like node.admin.css, which only contains a background colour, could possibly be removed altogether rather than merged?
- Status changed to Needs work
about 1 month ago 12:08pm 27 May 2024 The Needs Review Queue Bot โ tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- ๐ฎ๐ณIndia Mithun S Bangalore
Mithun S โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia Mithun S Bangalore
Mithun S โ changed the visibility of the branch 2421365-merge-node.css-files to hidden.