Olivero: Refactor the css for bold error message on removal of strong tag.

Hi @Gauravvv

The issue summary says the "twig file needs to be refacored", but this patch only contains CSS changes and removing the todo from the twig file doc block.

Is there any refactoring of the actual twig file needed?

The issue summary says the "twig file needs to be refacored", but this patch only contains CSS changes and removing the todo from the twig file doc block.

@markconroy As https://www.drupal.org/node/3010558 → is fixed.

So I have removed the todo comment from the twig file. And added the required CSS on form-item__error-message class. As suggested in parent issue.

Thanks @Gauravvv

Adding bold to the CSS for errors, means that the full error message will be bold. Is that the desired outcome? Or do we want only items with a strong tag in the error message to be bold?

Adding bold to the CSS for errors, means that the full error message will be bold. Is that the desired outcome? Or do we want only items with a strong tag in the error message to be bold?

Yes @markconroy, Same we have done in the parent issue 3010558: Unnecessary element in Umami's form-element template may produce invalid markup → .

<strong> may produce invalid markup. To avoid that we're adding bold to the CSS for errors.

<strong> may produce invalid markup. To avoid that we're adding bold to the CSS for errors.

Yes, but do we want the FULL error message to be in bold? If the error message is:

The following fields must be filled in: title, email, and phone number.

How can we show bold to only the words "title", "email", and "phone" if we have the full message set to use "bold".

If that's the desired result, then we can mark this RTBC.

Think since the .css file has changed that before/after screenshots should be added to the issue summary to show nothing broke.

Hello @smustgrave,
Can you please share steps to check this error message.
It will easy for me to share screenshot with After and before.

Mithun S → made their first commit to this issue’s fork.

Observed that all the strong tags in the files are removed, the css of bold for the error message is missing for 11.x. Added the required css and raised a new PR against 11.x branch. Please review.

Issue summary is incomplete. See tags

Updating the issue summary for the issue.