[drupalImage] Rename "Text alternative" field label to "Alternative text"

Updated the Text alternative field label to Alternative text kindly review it.

After Fix -

Thanks

Hi,
Tested And verified patch on Drupal version 11.x
The patch applied successfully...

Testing steps:
Followed the mentioned steps for the issue

Test Result:
The field label text is updated to "Alternative text"

Attaching screenshots for reference

Status "Need Review" for code review

MR has failures.

Keshav Patel → made their first commit to this issue’s fork.

MR 6520 is passed, Please Review.

Used the following reference to build: https://www.drupal.org/docs/core-modules-and-themes/core-modules/ckedito... →

Hi,
Tested the latest MR !6520 on Drupal version 11.x
The patch applied successfully...

Test Result:
The field label text is updated to "Alternative text"

Attaching screenshots for reference

Keeping it in Need review for code review
As code is pass, can move to RTBC

Why use a new MR vs the existing one that was pointed to the right branch? Should avoid clutter

IIRC this was done intentionally. I agree it should be consistent between drupalImage and drupalMedia though — that is a bug.

Can you please do the necessary git/issue queue archeology to describe why this choice was originally made (and link to that decision), and also describe why that was wrong? That information would be crucial to have in the issue summary 😊🙏

@wim-leers I did a search in DuckDuckGo and Google for pages on URLs beginning www.drupal.org/project/drupal/issues which contained both "text alternative" and "alternative text" (with quotes) as character strings. None of the issues which turned up as obvious choices had a discussion about which was the appropriate choice for the label.

I also searched for git.drupalcode.org content containing "text alternative," with no results in either engine.

I have updated the issue descriptions to add my reasoning as to why I believe "Alternative text" is the correct label.

Minor word omission fix

Recommend using the git blame on the file to find the ticket it was added in and if discussion was done for it.

I'm actually QA, not a developer, and setting up an environment to run git blame against Drupal core is beyond my knowledge.

\core\modules\ckeditor5\js\ckeditor5_plugins\drupalImage\src\imagealternativetext\ui\imagealternativetextformview.js
shows the line
labeledInput.label = Drupal.t('Text alternative');
was last committed with
c6d7b83fa35 (bnjmnm 2022-03-31 08:18:19 -0400 254)

However, if I search for c6d7b83fa35 on either drupal.org or git.drupalcode.org, I get no results.

I do see relevant issues involving @bnjmnm which were updated around that time:

• [drupalImage] Make image alt text required or strongly encouraged →
• [drupalMedia] Show the Image Media's default alt text that is being overridden →

The latter issue does have the comment:

Is "Default alternative text" the right term? Does it convey enough information?

I think that something like "Alternative text from Media Library" might be clearer?

but I don't see anything in the issue discussing "Alternative text" versus "Text alternative".

Amire → changed the visibility of the branch 3419894-rename-text-alternative to hidden.

Amire → changed the visibility of the branch 3419894-rename-text-alternative to active.

Here, I have applied MR !6520, and it was working successfully. I am attaching the screenshot for review. The Drupal version used is 11.x-dev.

Here, I have applied the MR !6520, and it was working for me. I am attaching the screenshot for review.
used version 11.x-dev
for the reff. i have attached the screen capture

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Mithun S → made their first commit to this issue’s fork.

Updated the original MR and fixed the Pipeline issue.

Appears the researched requested was done in #17 (saving credit for that and to @Wim Leers for the review)

For clarification, the research requested was done in #17 and #21.

The research is incomplete. We should investigate why the current string was adopted.

This string was added in #3222757: [drupalImage] Make image alt text required or strongly encouraged → .

The words first appear in accessibility maintainer @andrewmacpherson's comment at #3222757-32: [drupalImage] Make image alt text required or strongly encouraged → .

That's the only place it ever occurred, it seems 🤠

\Drupal\editor\Form\EditorImageDialog::buildForm() has said since 2015, as has its validation error if it's missing:
'#required_error' => $this->t('Alternative text is required.<br />(Only in rare cases should this be left empty. To create empty alternative text, enter <code>"" — two double quotes without any content).'),

So: +1! This is ready. Sorry for slowing us down, but I want to ensure we definitely get it right this time 😊

⚠️ More importantly, my research shows that thanks to this very string already existing in EditorImageDialog, this is not a string change, because the string already exists and hence already has a translation! 🥳

nod_ → closed merge request !6497

Awesome, and since the string exists, I'll backport to 10.2.x to have is asap :)

Committed c45941b and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.