Breadcrumb template overriding core template

Reproduced the issue on local, create a patch Breadcrumb-template-overriding-core-template-3338734-3.patch for this issue.

Perform Steps:
1. Install the Drupal 9.0.x version.
2. Install and set ZURB Foundation Theme and install Easy Breadcrumb module.
3. create and apply the patch.
4. Clear the cache and reload the page.

Testing result: Need review
Breadcrumb template overriding core template

Moved the issue to Need Review.

Hi @Harish1688,

Thanks for the work.

Verified and tested Patch Comment #3 on Drupal 10.1.x Applied patch cleanly

git apply -v Breadcrumb-template-overriding-core-template-3338734-3.patch
Checking patch templates/breadcrumb.html.twig...
Applied patch templates/breadcrumb.html.twig cleanly.

Testing Steps:-
1. Install Drupal 10.1.x version.
2. git clone --branch '9.x' git clone --branch '9.x' https://git.drupalcode.org/project/zurb-foundation.git.
2. Applied Patch #3 /projects/drupal-git/drupal/themes/contrib/zurb-foundation.
3. Checked the changes difference using git diff
4. Checked the Output looks good after applying a patch. Attached the screenshot for refernce.

Testing result:
Breadcrumb template overriding core template issue fix on Drupal 10.1.x. Moving the issue to RTBC

This looks good to me and I think it solves the issue, but it does add in new classes on the list items (`breadcrumb-item` and `active`) that aren't used as a part of Foundation, and I don't see them in core's templates in starterkit_theme or stable9.

I suggest we:
- remove the extra classes.
- put the if/else statement inside the <li> like it is in core.

Or if I'm overlooking the reason why we should add in those classes let me know.

Working on the feedbacks.

Adding a new patch file based on the feedback on the ticket. Please review the updated patch on the issue.

Hi @Mithun S, Tested patch your patch #8, it is applied cleanly.
As suggested by @sim_1, new patch #8 does not creates classes for li tags.
Also it resolves the issue of breadcrumb template overriding.

Steps I followed:

1. Installed Drupal 10.1.2 and installed zurb theme version 9.x through git.
2. Set theme as default.
3. Installed Easy Breadcrumb →
4. Applied patch and issue is now resolved.

Attaching screenshots, please check.

BEFORE

AFTER

As issue is now resolved, moving it to RTBC.