🇮🇳India @Abh1shek

Account created on 11 May 2022, almost 2 years ago
#

Recent comments

🇮🇳India Abh1shek

Hi MYIRO,
I am not able to reproduce the issue. Can you please give proper steps?

🇮🇳India Abh1shek

Rerolled the patch in current branch 1.2.x
Here are the steps I have followed:

1. Taken clone from git version 1.2.x in drupal 10.3.x
2. Found spelling mistake in src/Form and src/Plugin/Field/FieldWidget
3. Corrected the Height mistake.
4. Attaching screenshots and patch.

BEFORE (Heigth)
https://www.drupal.org/files/issues/2024-04-03/Screenshot%20from%202024-...

AFTER (Height)
https://www.drupal.org/files/issues/2024-04-03/Screenshot%20from%202024-...

🇮🇳India Abh1shek

Hi @sakthi_dev, thanks for the patch, I have reviewed your patch.

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/microblogging

3. Applied patch and again ran phpcs command,

Found 1 white space error after applying patch.

Found errors after ran phpcs command.

4. I ran phpcbf to fix errors and created a patch and fixed the remaining errors,

then again check with phpcs command found no errors.

Attached patch file and screenshots.

Please Review.

🇮🇳India Abh1shek

Hi @Mithun S, Tested patch your patch #8, it is applied cleanly.
As suggested by @sim_1, new patch #8 does not creates classes for li tags.
Also it resolves the issue of breadcrumb template overriding.

Steps I followed:

1. Installed Drupal 10.1.2 and installed zurb theme version 9.x through git.
2. Set theme as default.
3. Installed Easy Breadcrumb
4. Applied patch and issue is now resolved.

Attaching screenshots, please check.

BEFORE

AFTER

As issue is now resolved, moving it to RTBC.

🇮🇳India Abh1shek

Hello @apaderno,

I wanted to inform you that I have made some revisions to the issue summary. I have taken care to provide a comprehensive description. However, I must admit that I'm a bit puzzled by your statement regarding Drupal 8.9. You mentioned that the extension.list.theme functionality is absent, and drupal_get_path still needs to be used. My experience differs, as I have successfully installed a theme on Drupal 8.9 and seamlessly replaced drupal_get_path with extension.list.theme. The theme is functioning impeccably in this context.

Could you kindly offer some guidance on this matter? Your insights would be greatly appreciated. Thank you for your assistance.

🇮🇳India Abh1shek

Hi @paraderojether, your patch applied cleanly, but I found 1 error. Here are the steps I have followed:

1. Taken clone from git version 2.0.x in drupal 10.1.2
2. Applied your patch and ran the phpcs command
3. Found 1 error

4. Then ran the phpcbf command to fix that error. Now It is error free.

Attaching screenshots and patch.
Please review.

🇮🇳India Abh1shek

Hi @prachi6824, I applied your patch.

Here are the steps I followed:
1. Installed Drupal 10.1.2 version.
2. Took clone from git version 1.0.1
3. Installed theme and set it as default.
4. Applied Patch #2
5. Patch applied cleanly

The error is now fixed. Moving it to RTBC.

🇮🇳India Abh1shek

Hi @prachi6824, I applied your patch.

Here are the steps I followed:
1. Installed Drupal 10.1.2 version.
2. Took clone from git version 8.x-1.x
3. Installed theme and set it as default.
4. Applied Patch #2
5. Patch applied cleanly

Error for undefined function is now resolved, moving it to RTBC.

🇮🇳India Abh1shek

Hi @sonam_sharma, your patch applied cleanly.
I followed these steps:

1. Took clone from branch 8.0.x in drupal 10.1.2
2. Installed thex theme.
3. Installed theme and set it as default.
4. Applied the patch.

But error for undefine function is still there because you have made changes in theme-setting.php but the issue is occurring in edux.theme file.

I have created a patch. I replaced the deprecated function
drupal_get_path() with \Drupal::service('extension.list.theme')->getPath('edux'). Providing patch and screenshots.

BEFORE

AFTER

Please review.

🇮🇳India Abh1shek

Status was not changed from needs work to needs review as there is patch provided. Changing status to Needs review and also reviewing this patch.

🇮🇳India Abh1shek

Hi @sonam_sharma, your patch applied successfully.

The error for undefined function is now fixed. Attaching screeshots for before and after.

BEFORE

AFTER

Here are the steps I followed:

1. Took clone from branch 8.1.x in drupal 10.1.2
2. Installed theme and set it as default.
3. Applied the patch and works fine for me.

I think issue has been resolved. So, moving this to RTBC.

🇮🇳India Abh1shek

Status was not changed from needs work to needs review as there is patch provided. Changing status to Needs review and also reviewing this patch.

🇮🇳India Abh1shek

I have created a patch for this issue. Here are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.2
2. Installed and set the theme as default
3. Installed latest bootstrap5 theme from composer
3. Replaced the deprecated function drupal_get_path() with \Drupal::service('extension.list.theme')->getPath('idyllic')

Now it is working fine. Please review.

🇮🇳India Abh1shek

Created patch for the issue. Here are the steps I followed:
1. Took clone of ajans project.
2. Installed ajans and set it default.
3. Created an article.
4. Written css in theme.css file for footer section.

Attaching patch file and screenshot after applying my changes. Please review.

🇮🇳India Abh1shek

I installed classy theme as suggested. Now 3363825-6.patch and 3363825-9.patch, both are working. There is no error now. Attaching screenshot. Thank you @arti_parmar and @keshav.k for the patch. Moving it to RTBC.

🇮🇳India Abh1shek

Hi @arti_parmar, I applied your patch.

Here are the steps I followed:
1. Install Drupal 10.1.x version.
2. git clone --branch '1.0.x' https://git.drupalcode.org/project/ajans.git
3. Applied Patch #6 /themes/contrib/ajans
4. Checked the changes difference using git diff
5. Installed theme and set it as default.

The error for core_Version_requirement is resolved but there is still an error. Attaching screenshot. Changing the status to Needs work.

🇮🇳India Abh1shek

Adding patch for spacing above footer and screenshot for the same.

🇮🇳India Abh1shek

Hi @swatidhurandhar, I applied your patch, but I found some errors while applying patch. Attaching error screenshot.

🇮🇳India Abh1shek

Hi @admin_juhisingh, I applied your patch & It is working fine. But when I add any content to the homepage, there is very minimal space below the navigation bar. Please add more space below that.

Patch cleanly applied

Patch working fine

No spacing below nav bar

🇮🇳India Abh1shek

Hi @Akshay kashyap, your patch is applied successfully and it is working fine. The alignment issue of search input field is fixed now. Attached Screenshot. Moving it to RTBC.

🇮🇳India Abh1shek

Hi @ravi kant, I checkout to your branch "3362675-incorrect-alignment-of". But still the issue of incorrect alignment is not fixed. Please check attached screenshot.

🇮🇳India Abh1shek

Hi @Akshay kashyap,
patch is successfully applied and spacing between content and image in the footer is added.

Moving it to RTBC.

🇮🇳India Abh1shek

Hi @Project Update Bot,
Verified and tested Patch Comment #2 on drupal 10.0.x.

Testing Steps:-
1. Install drupal 10.0.x version
2. git clone https://git.drupalcode.org/project/ecwid_shopping_cart.git
2. Applied Patch #2
3. Checked the changes difference using git diff
4. Installed module
5. Click on Cart -> Setup -> Connect

Testing result:
Ecwid Ecommerce Shopping Cart compatible with drupal 10.0.x

But found 3 errors with drupal-check

------ --------------------------------------------------------------
Line src/Controller/Connect.php
------ --------------------------------------------------------------
38 Call to an undefined static method
Symfony\Component\HttpFoundation\RedirectResponse::create().
70 Call to an undefined static method
Symfony\Component\HttpFoundation\RedirectResponse::create().
74 Call to an undefined static method
Symfony\Component\HttpFoundation\RedirectResponse::create().
------ --------------------------------------------------------------

[ERROR] Found 3 errors

Drupal coding standards needs to be fixed.

🇮🇳India Abh1shek

@ashishsingh27 I've created a new patch for it. It is working fine now. Please apply this patch and test it in your local drupal D10 setup.

🇮🇳India Abh1shek

@ashishsingh27 I have tested this theme on our local drupal 10 setup and it's working fine. now we will port these theme in drupal 10.
Thanks.

Production build https://api.contrib.social 0.62.1