Second level should be marked as active and expanded when level three menu item is active

Created on 4 April 2024, 9 months ago
Updated 8 May 2024, 7 months ago

Problem/Motivation

When I'm visiting a page that is linked as a level three menu item, I would expect both the level 1 and 2 items to be highlighting the active trail. This includes keeping the second level menu item open by default to be able to show the active menu item:

On top of this, we should make sure that the active trail is shown in the menu even when user is on a page that is not directly linked from the navigation. This was fixed recently in the core Toolbar module, which we could potentially use as an inspiration for the fix: 🐛 Toolbar doesn't indicate active menu trail for pages not included in Toolbar Fixed .

Steps to reproduce

Proposed resolution

Link to designs on Figma to see all the states.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Needs work

Version

11.0 🔥

Component
Navigation 

Last updated about 9 hours ago

No maintainer
Created by

🇫🇮Finland lauriii Finland

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @lauriii
  • Assigned to Abh1shek
  • 🇮🇳India Abh1shek

    I am working on this issue.

  • Issue was unassigned.
  • Status changed to Needs review 9 months ago
  • 🇮🇳India Abh1shek

    Fixed the issue, please review.

  • Pipeline finished with Success
    9 months ago
    Total: 254s
    #137418
  • First commit to issue fork.
  • Merge request !234Resolve #3438046: "2nd level active state" → (Open) created by ckrina
  • 🇪🇸Spain ckrina Barcelona

    Moved the work to branch that follow naming conventions to avoid confusions.

  • Pipeline finished with Success
    9 months ago
    Total: 221s
    #139450
  • 🇪🇸Spain ckrina Barcelona

    Apart from the feedback on the JS strategy, the active state should have the dark circle when it's active. You can explore the designs in Figma here. And I've added a link to the issue summary.

  • Status changed to Needs work 9 months ago
  • 🇪🇸Spain ckrina Barcelona
  • Assigned to meghasharma
  • Pipeline finished with Success
    8 months ago
    Total: 242s
    #147831
  • 🇮🇳India meghasharma

    Added dark circle to active state when it's active as per the figma design.
    Please review
    Thanks!
    Screenshot 2024-04-16 at 2.46.36 PM
    Screenshot 2024-04-16 at 2.46.53 PM

  • Issue was unassigned.
  • Status changed to Needs review 8 months ago
  • Status changed to Needs work 8 months ago
  • 🇷🇸Serbia finnsky

    This should be rebased first i guess.

  • Assigned to meghasharma
  • Issue was unassigned.
  • 🇪🇸Spain ckrina Barcelona
  • 🇪🇸Spain ckrina Barcelona
  • First commit to issue fork.
  • Status changed to Needs review 7 months ago
  • 🇮🇳India gauravvvv Delhi, India
  • Pipeline finished with Failed
    7 months ago
    Total: 742s
    #167528
  • Status changed to Needs work 7 months ago
  • 🇺🇸United States smustgrave

    With the js change believe something that should have test coverage.

  • 🇷🇸Serbia finnsky

    Thank you!
    MR contains lot of css changes which breaks layout

    Also i believe it does not need rework of all JS, Cause all events already exist. Gonna check

  • Merge request !7964Don't close buttons on popover toggle → (Open) created by finnsky
  • Pipeline finished with Success
    7 months ago
    Total: 573s
    #167618
  • Status changed to Needs review 7 months ago
  • 🇷🇸Serbia finnsky

    It needs design and UI decision.

    In the original version of the menu, we had limited space in the popover and closed the child menu when changing the popover. Now I think
    this is completely unnecessary because there is enough space in the popover to display the children's menu open.

    This MR resolve it. But not works in case of deeper levels. We need to rewrite events system a bit to achieve this.

  • 🇷🇸Serbia finnsky

    Now works with any level of nesting.

  • Pipeline finished with Success
    7 months ago
    Total: 579s
    #167641
  • 🇪🇸Spain ckrina Barcelona

    ckrina changed the visibility of the branch 3438046-2nd-level-active to hidden.

  • Status changed to Needs work 7 months ago
  • 🇷🇸Serbia finnsky

    We need to add extra css using `:has` selector

    https://developer.mozilla.org/en-US/docs/Web/CSS/:has

    Examples presented for higher levels of menu

  • 🇺🇸United States sjothivelu@valleywater.org

    Hello,

    I am looking into this.

  • Pipeline finished with Failed
    6 months ago
    Total: 113s
    #208822
  • Pipeline finished with Success
    6 months ago
    Total: 180s
    #208825
  • Pipeline finished with Success
    6 months ago
    #210718
  • Pipeline finished with Skipped
    6 months ago
    #213059
  • Pipeline finished with Failed
    6 months ago
    Total: 53s
    #216449
  • Pipeline finished with Success
    6 months ago
    Total: 52s
    #216480
  • Pipeline finished with Success
    6 months ago
    Total: 3818s
    #216496
  • Pipeline finished with Failed
    4 months ago
    Total: 398s
    #269390
  • Pipeline finished with Failed
    4 months ago
    Total: 374s
    #269454
  • Pipeline finished with Failed
    4 months ago
    Total: 406s
    #269466
  • Pipeline finished with Failed
    4 months ago
    #269474
  • Pipeline finished with Failed
    4 months ago
    Total: 401s
    #269482
  • Pipeline finished with Failed
    4 months ago
    Total: 419s
    #269507
  • Pipeline finished with Failed
    4 months ago
    Total: 370s
    #269674
  • Pipeline finished with Success
    4 months ago
    Total: 278s
    #269749
  • Pipeline finished with Success
    4 months ago
    Total: 291s
    #269754
  • Pipeline finished with Failed
    4 months ago
    Total: 279s
    #269774
  • Pipeline finished with Success
    4 months ago
    Total: 713s
    #269787
  • Pipeline finished with Skipped
    4 months ago
    #269875
  • Pipeline finished with Skipped
    4 months ago
    #269949
  • Pipeline finished with Skipped
    4 months ago
    #270330
  • Pipeline finished with Failed
    4 months ago
    Total: 670s
    #272349
  • Pipeline finished with Failed
    4 months ago
    Total: 498s
    #272370
  • Pipeline finished with Running
    4 months ago
    #272385
  • Pipeline finished with Success
    4 months ago
    Total: 600s
    #273215
  • Pipeline finished with Failed
    3 months ago
    Total: 367s
    #296185
  • Pipeline finished with Success
    3 months ago
    Total: 346s
    #301084
  • Pipeline finished with Failed
    about 1 month ago
    Total: 207s
    #328848
  • Pipeline finished with Success
    about 1 month ago
    Total: 158s
    #328854
  • Pipeline finished with Success
    about 1 month ago
    Total: 221s
    #337237
  • Pipeline finished with Failed
    about 1 month ago
    Total: 336s
    #338291
  • Pipeline finished with Failed
    24 days ago
    Total: 514s
    #349571
  • Pipeline finished with Failed
    24 days ago
    Total: 62s
    #349575
  • Pipeline finished with Failed
    24 days ago
    Total: 558s
    #349582
  • Pipeline finished with Canceled
    19 days ago
    Total: 73s
    #354784
  • Pipeline finished with Success
    19 days ago
    Total: 145s
    #354785
  • Pipeline finished with Success
    19 days ago
    Total: 145s
    #354786
  • Pipeline finished with Success
    15 days ago
    Total: 131s
    #359362
  • Pipeline finished with Success
    15 days ago
    Total: 141s
    #359364
Production build 0.71.5 2024