- Issue created by @ashutosh ahirwal
- Issue was unassigned.
- Status changed to Needs review
about 2 years ago 11:28am 30 January 2023 - 🇮🇳India ashutosh ahirwal India
Providing patch for reference.
theme-compatibility - First commit to issue fork.
- Status changed to Needs work
about 2 years ago 9:09pm 20 February 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
core: 8.x -core_version_requirement: ^8 || ^9 +core_version_requirement: ^8 || ^9 || ^10
core
cannot be used with that value ofcore_version_requirement
. - 🇮🇳India ashishsingh27
Here is a patch to get it working on drupal 10.
As mentioned by @apaderno, since,
core
can note be used have removed it. and added it likecore_version_requirement: ^8.8 || ^9 || ^10
.prior to 8.7
core_version_requiremnt
is not there.
maybe this link will be helpful https://www.drupal.org/node/3070687 →Also, for
File::load($fid[0]
it was getting null value hence have added condition to check for Null. - Status changed to Needs review
about 2 years ago 11:16am 22 February 2023 - 🇮🇳India Abh1shek
@ashishsingh27 I have tested this theme on our local drupal 10 setup and it's working fine. now we will port these theme in drupal 10.
Thanks. - 🇮🇳India Abh1shek
@ashishsingh27 I've created a new patch for it. It is working fine now. Please apply this patch and test it in your local drupal D10 setup.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Since there are not clear instructions a novice user can follow, this is not a novice issue.
- Status changed to Needs work
almost 2 years ago 10:57am 5 April 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
core: 8.x -core_version_requirement: ^8 || ^9 +core_version_requirement: ^8 || ^9 || ^10
With that
core_version_requirement
value,core
cannot be anymore used. Also,core_version_requirement
should becore_version_requirement: ^8.8 || ^9 || ^10
becausecore_version_requirement
is not recognized in earlier Drupal versions.Has anybody verified the code is really compatible with Drupal 10? Is the code still using functions/methods that have been removed from Drupal 10?
- Assigned to shivam_tiwari
- @shivam_tiwari opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 8:03am 10 April 2023 - First commit to issue fork.
-
arti_parmar →
committed cb8aeb57 on 1.0.x authored by
shivam_tiwari →
Issue #3337553 by Abh1shek Chauhan, Ashutosh Ahirwal, ashishsingh27,...
-
arti_parmar →
committed cb8aeb57 on 1.0.x authored by
shivam_tiwari →
- Status changed to Fixed
over 1 year ago 7:15am 8 June 2023 - 🇮🇳India arti_parmar
I have reviewed the changes and tested them. I will merge them.
- @arti_parmar opened merge request.
- Status changed to Fixed
over 1 year ago 1:51pm 12 June 2023