- Issue created by @sonam_sharma
- Issue was unassigned.
- Status changed to Needs work
about 1 year ago 9:36am 3 July 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
The issue summary should always describe what should be fixed/changed. Neither the title nor screenshots are sufficient to describe what the issue is, even in the case a patch is provided.
In the case of a bug, the description should also list the steps necessary to reproduce the issue, starting from when the module/theme is installed. - Status changed to Needs review
about 1 year ago 7:34pm 5 August 2023 - ๐ฎ๐ณIndia Abh1shek
I have created a patch for this issue. Here are the steps I followed:
1. Took clone from git version 1.0.x in drupal 10.1.2
2. Installed and set the theme as default
3. Installed latest bootstrap5 theme from composer
3. Replaced the deprecated function drupal_get_path() with \Drupal::service('extension.list.theme')->getPath('idyllic')Now it is working fine. Please review.
- Status changed to Needs work
about 1 year ago 7:34am 6 August 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
The status is for the issue summary which, apart from quoting an error message, it does not say much on how to reproduce the issue. In any case, quoting an error message is never sufficient for a bug report.
The issue summary must be updated. - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
-core_version_requirement: '^8.9 || ^9' +core_version_requirement: '^8.9 || ^9 || ^10'
That change is also not correct: Drupal 8.9 does not have the extension.list.theme service and it still needs to use d
rupal_get_path()
; this issue is not about making the module installable on Drupal 10. - ๐ฎ๐ณIndia Abh1shek
Hello @apaderno,
I wanted to inform you that I have made some revisions to the issue summary. I have taken care to provide a comprehensive description. However, I must admit that I'm a bit puzzled by your statement regarding Drupal 8.9. You mentioned that the extension.list.theme functionality is absent, and drupal_get_path still needs to be used. My experience differs, as I have successfully installed a theme on Drupal 8.9 and seamlessly replaced drupal_get_path with extension.list.theme. The theme is functioning impeccably in this context.
Could you kindly offer some guidance on this matter? Your insights would be greatly appreciated. Thank you for your assistance.
- ๐ฎ๐ณIndia ravi kant Jaipur
ravi kant โ made their first commit to this issueโs fork.
- Status changed to Needs review
3 months ago 11:54am 12 June 2024 - ๐ฎ๐ณIndia ravi kant Jaipur
The patch is applying and issue is solving for me so creating MR.
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
Right, it's the
ExtensionPathResolver
class that is missing in Drupal 8. The documentation fordrupal_get_path()
suggests using that class, but for what I can see the extension.list.theme service would work too.Yet, the
ThemeExtensionList
class is marked internal. Contributed modules and themes should not use that class, since it is an internal class.