Workspaces toolbar appears very broken

I am working on it.

I was able to reproduce this issue in gin theme by installing workspace module and after that on clicking on Live/Stage button on header.
I have uploaded patch to fix this.
Thanks

Hi @swatidhurandhar, I applied your patch, but I found some errors while applying patch. Attaching error screenshot.

Hi @Abh1shek Chauhan I can see you are inside gin theme, so it is not able to find the path of all the files(which is theme/contrib/gin/dist/css/..). You should be outside theme folder which is 'drupal_OS' in your case and then try to apply the patch. It should work.

Hi swatidhurandhar i have applied your patch and it is working fine for me and now the workspace toolbar appearing nice for me. so moving this to RTBC.

I don't think the patch works in all layouts (see attached).

The patch in #4 is working well for me, but the paths should be relative to the theme so it can be applied with composer. Here is a patch with updated paths.

Hi @davisben,
I have tested patch #12 and it has been successfully applied workspace toolbar is looking good to me now.
Attached screenshot -

Patch files are no longer recommended so I created MR for the above.
Thanks

Darren Oh → made their first commit to this issue’s fork.

ahsannazir → closed merge request !358

ahsannazir → reopened merge request !358

The one of the piplelines is broken. I tried raising another MR but no luck

ahsannazir → closed merge request !359

Hi @ahsannazir, i applied MR #21, it's working as expected.

For reference:-
Before MR

After MR

Pipelines issue need to fixed so moving this to NW.

Pipelines are passing now. so moving to NR

Verified the issue and is fixed. Verified with MR!358 #21
Testing steps :
* Install the Workspaces module
* Create a second workspace at /admin/config/workflow/workspaces
* click on "Stage" the Workspace toolbar

Moving to RTBC++

Added the workspaces icon to the menu tab. Ready for review.

The workspaces icon is not fully visible see the screenshot.

Your screen shot shows that your browser is using a cached icon sprite that does not have the workspaces icon.

Hi @Darren!
I've tested MR !358 on Drupal 10.2.2.
Noticed that the workspaces icon isn't fully visible after refreshing the page.
If there's anything I might have overlooked, especially the Drupal version, please let me know!

Attaching screenshot

Your screen shot shows the top of the icon sprite, which means your browser is using a cached sprite that does not have the workspaces icon. Try clearing your browser cache or using a private browsing window. I have added testing instructions to the issue summary.

I updated the MR so it applies to the latest branch cleanly. I regenerated the CSS, but front-end development is not my strong suite, so hopefully I did that correctly.

However, I'm unable to apply the patch due to it containing binary file changes. I got around that by simply removing those changes in my local patch file, but then I'm missing some icons. How are others testing this?

A few notes:

I'm still seeing the issue reported in #29 (likely due to my patching issue).

Style to match Gin branding.

This is listed in the issue description, and I think it would be great to try to do this still. If someone can point me in the right direction on the approach we want to take, I can take a swing at it.

While the MR in its current state is a big improvement. The interface is still very different from anything else rendered in the Gin theme. This seems to be due to the CSS from the core module. Perhaps we need to be more aggressive in overriding it to provide a cohesive admin experience?

Toolbar with the current state of the MR:

For anyone else encountering this, the Workspaces Extra module → provides a much cleaner interface that "solved" this issue for us.