- Issue created by @dalin
- ๐ฎ๐ณIndia swatidhurandhar
I was able to reproduce this issue in gin theme by installing workspace module and after that on clicking on Live/Stage button on header.
I have uploaded patch to fix this.
Thanks - Status changed to Needs review
11 months ago 11:14am 25 July 2023 - Status changed to Needs work
11 months ago 6:09am 26 July 2023 - ๐ฎ๐ณIndia Abh1shek
Hi @swatidhurandhar, I applied your patch, but I found some errors while applying patch. Attaching error screenshot.
- ๐ฎ๐ณIndia swatidhurandhar
Hi @Abh1shek Chauhan I can see you are inside gin theme, so it is not able to find the path of all the files(which is theme/contrib/gin/dist/css/..). You should be outside theme folder which is 'drupal_OS' in your case and then try to apply the patch. It should work.
- Status changed to Needs review
11 months ago 7:49am 26 July 2023 - last update
11 months ago Patch Failed to Apply - Status changed to RTBC
11 months ago 5:45am 27 July 2023 - ๐ฎ๐ณIndia mukesh-kumar3 Dharmshala
Hi swatidhurandhar i have applied your patch and it is working fine for me and now the workspace toolbar appearing nice for me. so moving this to RTBC.
- Status changed to Needs work
9 months ago 9:14pm 12 October 2023 - ๐บ๐ธUnited States webdrips
I don't think the patch works in all layouts (see attached).
- last update
8 months ago Patch Failed to Apply - ๐บ๐ธUnited States davisben NH
The patch in #4 is working well for me, but the paths should be relative to the theme so it can be applied with composer. Here is a patch with updated paths.
- First commit to issue fork.
Hi @davisben,
I have tested patch #12 and it has been successfully applied workspace toolbar is looking good to me now.
Attached screenshot -- Merge request !346gin-3376700: Fixed the workspace toolbar style issue. โ (Open) created by shweta__sharma
- Status changed to Needs review
6 months ago 12:20pm 19 December 2023 Patch files are no longer recommended so I created MR for the above.
Thanks- ๐บ๐ธUnited States Darren Oh Lakeland, Florida
Darren Oh โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia ehsann_95
ahsannazir โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia ehsann_95
The one of the piplelines is broken. I tried raising another MR but no luck
- Status changed to Needs work
6 months ago 8:09am 12 January 2024 - ๐ฎ๐ณIndia djsagar
Hi @ahsannazir, i applied MR #21, it's working as expected.
For reference:-
Before MR
After MR
Pipelines issue need to fixed so moving this to NW.
- Status changed to Needs review
5 months ago 6:00am 15 January 2024 - Status changed to RTBC
5 months ago 1:28pm 15 January 2024 - ๐ฎ๐ณIndia divya.sejekan
Verified the issue and is fixed. Verified with MR!358 #21
Testing steps :
* Install the Workspaces module
* Create a second workspace at /admin/config/workflow/workspaces
* click on "Stage" the Workspace toolbarMoving to RTBC++
- Status changed to Needs review
4 months ago 5:36pm 16 February 2024 - ๐บ๐ธUnited States Darren Oh Lakeland, Florida
Added the workspaces icon to the menu tab. Ready for review.
- Status changed to Needs work
4 months ago 7:43am 19 February 2024 The workspaces icon is not fully visible see the screenshot.
- Status changed to Needs review
4 months ago 12:40pm 19 February 2024 - ๐บ๐ธUnited States Darren Oh Lakeland, Florida
Your screen shot shows that your browser is using a cached icon sprite that does not have the workspaces icon.
- Status changed to Needs work
4 months ago 8:13am 20 February 2024 - ๐ฎ๐ณIndia Kanchan Bhogade
Hi @Darren!
I've tested MR !358 on Drupal 10.2.2.
Noticed that the workspaces icon isn't fully visible after refreshing the page.
If there's anything I might have overlooked, especially the Drupal version, please let me know!Attaching screenshot
- Status changed to Needs review
4 months ago 1:27pm 20 February 2024 - ๐บ๐ธUnited States Darren Oh Lakeland, Florida
Your screen shot shows the top of the icon sprite, which means your browser is using a cached sprite that does not have the workspaces icon. Try clearing your browser cache or using a private browsing window. I have added testing instructions to the issue summary.