πŸ‡ΊπŸ‡ΈUnited States @davisben

NH
Account created on 5 March 2011, over 13 years ago
#

Merge Requests

Recent comments

πŸ‡ΊπŸ‡ΈUnited States davisben NH

Thanks for confirming! I'll fix the tests and get it committed.

πŸ‡ΊπŸ‡ΈUnited States davisben NH

I think this should do it. Give it a try and see if it meets your needs.

πŸ‡ΊπŸ‡ΈUnited States davisben NH

This has been merged. Thanks!

πŸ‡ΊπŸ‡ΈUnited States davisben NH

I'm having trouble trying to reproduce this. Here are a few things to check:

  • Confirm you have an AWS profile configured, and that it has the proper permissions.
  • Do you also get on error on the Statistics page?
  • Are there any messages in the logs with additional info?
πŸ‡ΊπŸ‡ΈUnited States davisben NH

That isn't currently an option, but it should be fairly easy to add.

πŸ‡ΊπŸ‡ΈUnited States davisben NH

Looks good, thanks!

πŸ‡ΊπŸ‡ΈUnited States davisben NH

The patch in #4 is working well for me, but the paths should be relative to the theme so it can be applied with composer. Here is a patch with updated paths.

πŸ‡ΊπŸ‡ΈUnited States davisben NH

I addressed the concerns in #4, and rebased against 2.0.x.

πŸ‡ΊπŸ‡ΈUnited States davisben NH

davisben β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States davisben NH

Thanks, it looks good to me. Merged!

πŸ‡ΊπŸ‡ΈUnited States davisben NH

Thanks for the links! I'd like ot keep this module fairly simple, but I'll take a look and see what might be a good fit to move over.

πŸ‡ΊπŸ‡ΈUnited States davisben NH

Thanks for the MR! I've been wanting to do this. I'll give it a review in the next day or so.

πŸ‡ΊπŸ‡ΈUnited States davisben NH

I added a readme file with this info, and also added it to the project page.

πŸ‡ΊπŸ‡ΈUnited States davisben NH

Thanks for the report! This code was built around the old TXT record verification, so it is in need of updating to support DKIM.

πŸ‡ΊπŸ‡ΈUnited States davisben NH

I'm also seeing this with Gin. It looks like it was introduced in ✨ Tabbing order does not satisfy 508 accessibility requirements Needs review . I'm not sure if the fix should happen here or in Gin.

πŸ‡ΊπŸ‡ΈUnited States davisben NH

I'm running into the same error. It is happening with the Group module enabled, because Group uses hyphens in bundles.

πŸ‡ΊπŸ‡ΈUnited States davisben NH

Thanks for the suggestion!

πŸ‡ΊπŸ‡ΈUnited States davisben NH

I agree, this is a good idea. I'll compile a list and add it to the docs.

πŸ‡ΊπŸ‡ΈUnited States davisben NH

davisben β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States davisben NH

Good catch! That has also been updated now.

πŸ‡ΊπŸ‡ΈUnited States davisben NH

I'll be working on this.

πŸ‡ΊπŸ‡ΈUnited States davisben NH

davisben β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States davisben NH

Makes sense. Since it's breaking, I'm going to start a 3.0.x branch.

Production build 0.69.0 2024