🇺🇸United States @davisben

Thanks for all your work on this!

I think a counter makes sense.

I rebased against 3.x and did a quick review. The changes look good, but I don't have any expiring credentials set up to test with. If someone can confirm this works as intended, I'll get it committed.

davisben → made their first commit to this issue’s fork.

This has been fixed and merged.

davisben → made their first commit to this issue’s fork.

I converted the most recent patch to a MR and fixed a bug with default config overwriting values that are already set.

This seems like a good idea. I just took a quick look and need to go through it in more detail, but I think we can probably implement \Drupal\Core\Queue\DelayableQueueInterface and use that to handle the delaying of queue items.

Sure does. I just cherry picked it to 3.x. Thanks!

Thanks for the patch!

Thanks! This has been committed.

I just tagged 3.1.0.

Patch doesn't apply to the latest dev. Here's a reroll.

I ran ran into this issue also. I got it working by checking if a pass-reset-token query parameter exists, and if so, ignore any configured destinations. This is almost certainly not a fix that covers all use cases, but I'm posting the patch in case it's helpful to anyone else.

This should be fixed now. If a profile was created before Encrypt was enabled, the encryption_profile would be set to null instead of _none. I added an update hook to update any existing profiles.

Could you check your config to see what value you have for encryption_profile? If that is set to the default value of "_none", encryption should already be skipped.

Looks good to me. Thanks for this!

davisben → made their first commit to this issue’s fork.

Sorry for the delay on this!

davisben → made their first commit to this issue’s fork.

Good catch. Thanks for the MR!

Merged.

davisben → created an issue.

davisben → created an issue.

I took a different approach by implementing hook_queue_info_alter() to remove the mail queue from cron when it's not enabled. Could you give this a test and see if it works as you expect it to?

davisben → changed the visibility of the branch 3417090 to hidden.

davisben → made their first commit to this issue’s fork.

davisben → created an issue.

Looks like we'll need to add an implement format() for the mailer. Currently, we just use the default implementation, which doesn't appear to support HTML. As a workaround in the meantime, you can use a different formatter the does support HTML, like the Webform PHP mailer.

I made some changes so it plays nice with Webform, or any other module that sets a from address. Could you give it another test?

davisben → made their first commit to this issue’s fork.

Thanks for confirming! I'll fix the tests and get it committed.

I think this should do it. Give it a try and see if it meets your needs.

This has been merged. Thanks!

I'm having trouble trying to reproduce this. Here are a few things to check:

• Confirm you have an AWS profile configured, and that it has the proper permissions.
• Do you also get on error on the Statistics page?
• Are there any messages in the logs with additional info?

That isn't currently an option, but it should be fairly easy to add.

Looks good, thanks!

The patch in #4 is working well for me, but the paths should be relative to the theme so it can be applied with composer. Here is a patch with updated paths.

I addressed the concerns in #4, and rebased against 2.0.x.

davisben → created an issue.

Thanks, it looks good to me. Merged!

Thanks for the links! I'd like ot keep this module fairly simple, but I'll take a look and see what might be a good fit to move over.

Thanks for the MR! I've been wanting to do this. I'll give it a review in the next day or so.

I added a readme file with this info, and also added it to the project page.

Thanks for the report! This code was built around the old TXT record verification, so it is in need of updating to support DKIM.

Merged!

I'm also seeing this with Gin. It looks like it was introduced in ✨ Tabbing order does not satisfy 508 accessibility requirements Needs review . I'm not sure if the fix should happen here or in Gin.

davisben → created an issue.

I'm running into the same error. It is happening with the Group module enabled, because Group uses hyphens in bundles.

davisben → made their first commit to this issue’s fork.

Thanks for the suggestion!

I agree, this is a good idea. I'll compile a list and add it to the docs.

davisben → made their first commit to this issue’s fork.

Good catch! That has also been updated now.

I'll be working on this.

davisben → made their first commit to this issue’s fork.

Looks good to me. Thanks!

Makes sense. Since it's breaking, I'm going to start a 3.0.x branch.